[PATCH v4 09/12] emacs: relax tag syntax check in `notmuch-tag' function

diff --git a/bc/121453578a7d5643164141158bf1534edc3278 b/bc/121453578a7d5643164141158bf1534edc3278
new file mode 100644 (file)
index 0000000..ac0d4d6
--- /dev/null
+++ b/bc/121453578a7d5643164141158bf1534edc3278
@@ -0,0 +1,85 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9289741732D\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 20:56:20 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 7vQJLaNhrMDQ for <notmuch@notmuchmail.org>;\r
+       Mon, 30 Jan 2012 20:56:19 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AC7F2417333\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 20:56:02 -0800 (PST)\r
+Received: by mail-bk0-f53.google.com with SMTP id 11so2152468bke.26\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 20:56:02 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=i9/cTLPd7bOFMr04kuAQdAaY5dNb+qyorxpNeYymWY0=;\r
+       b=F9CZZzq7aLWrc4P4ccgOpF05mcu4CN/YMMG32w3NnlUGlNZdjzxfT0QuFB/zX9XZ7k\r
+       Ok4JGyTcXhrRSHS/erA5j55XwO2TWjDnb3Hj968Zd1/IGCXCmpUt6uxzd7vqPTRqD3pC\r
+       6ZLFj9DVqldAQgd62rcTpgSsfEvlveZG0UmSA=\r
+Received: by 10.204.141.9 with SMTP id k9mr2338766bku.93.1327985762354;\r
+       Mon, 30 Jan 2012 20:56:02 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id ev5sm42537768bkb.4.2012.01.30.20.56.01\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 30 Jan 2012 20:56:01 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v4 09/12] emacs: relax tag syntax check in `notmuch-tag'\r
+       function\r
+Date: Tue, 31 Jan 2012 08:54:23 +0400\r
+Message-Id: <1327985666-29191-10-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-Mailer: git-send-email 1.7.9\r
+In-Reply-To: <1327985666-29191-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1327901644-15799-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1327985666-29191-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 31 Jan 2012 04:56:21 -0000\r
+\r
+The tag syntax check in `notmuch-tag' function was too strict and did\r
+not allow nmbug tags with "::".  Since the check is done for all\r
+tagging operations in Emacs UI, this basically means that no nmbug\r
+tags can be changed.  The patch relaxes the tag syntax check to allow\r
+any tag names that do not include whitespace characters.\r
+---\r
+ emacs/notmuch.el |    2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index 0a3bd17..2332c42 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -556,7 +556,7 @@ notmuch-after-tag-hook will be run."\r
+   ;; Perform some validation\r
+   (when (null tags) (error "No tags given"))\r
+   (mapc (lambda (tag)\r
+-        (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag)\r
++        (unless (string-match-p "^[-+]\\S-+$" tag)\r
+           (error "Tag must be of the form `+this_tag' or `-that_tag'")))\r
+       tags)\r
+   (run-hooks 'notmuch-before-tag-hook)\r
+-- \r
+1.7.9\r
+\r