[PATCH 1/3] lib: Don't delete uninitialized pointers

diff --git a/61/f975f757fb741e370d464852c63a149a47b382 b/61/f975f757fb741e370d464852c63a149a47b382
new file mode 100644 (file)
index 0000000..14fcbcd
--- /dev/null
+++ b/61/f975f757fb741e370d464852c63a149a47b382
@@ -0,0 +1,96 @@
+Return-Path: <amthrax@drake.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 617FE431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 21:50:17 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 64oBZNsTE7Wg for <notmuch@notmuchmail.org>;\r
+       Sat, 28 Jan 2012 21:50:16 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
+       [18.7.68.35])\r
+       by olra.theworths.org (Postfix) with ESMTP id 520C6431FD2\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 21:50:16 -0800 (PST)\r
+X-AuditID: 12074423-b7f9c6d0000008c3-84-4f24de165507\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id BC.EA.02243.61ED42F4; Sun, 29 Jan 2012 00:50:15 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q0T5oEnN009502; \r
+       Sun, 29 Jan 2012 00:50:14 -0500\r
+Received: from drake.mit.edu\r
+       (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com\r
+       [209.6.116.242]) (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0T5oCF4028023\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sun, 29 Jan 2012 00:50:13 -0500 (EST)\r
+Received: from amthrax by drake.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amthrax@drake.mit.edu>)\r
+       id 1RrNeV-0007ab-Vk; Sun, 29 Jan 2012 00:50:12 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 1/3] lib: Don't delete uninitialized pointers\r
+Date: Sun, 29 Jan 2012 00:50:08 -0500\r
+Message-Id: <1327816210-29124-1-git-send-email-amdragon@mit.edu>\r
+X-Mailer: git-send-email 1.7.7.3\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsUixG6nrit+T8Xf4PFrRovrN2cyOzB6PFt1\r
+       izmAMYrLJiU1J7MstUjfLoEr49S8+ywFk9krXnXfYmlgfMXaxcjJISFgInFm3U8mCFtM4sK9\r
+       9WxdjFwcQgL7GCWu/F3KCOFsYJTYe/szVOY+k8Tv2c9ZIJz5jBJN65Yxg/SzCWhIbNu/nBHE\r
+       FhGQlth5dzbQDg4OZgE1iT9dKl2M7BzCArYS781AClgEVCWunLjKBmLzCjhIHOu4wAhxhILE\r
+       udXn2Ccw8i5gZFjFKJuSW6Wbm5iZU5yarFucnJiXl1qka6aXm1mil5pSuokRHAIuyjsY/xxU\r
+       OsQowMGoxMOrsELFX4g1say4MvcQoyQHk5Io74I7QCG+pPyUyozE4oz4otKc1OJDjBIczEoi\r
+       vI4zgXK8KYmVValF+TApaQ4WJXFeDa13fkIC6YklqdmpqQWpRTBZGQ4OJQneuLtAjYJFqemp\r
+       FWmZOSUIaSYOTpDhPEDDPUBqeIsLEnOLM9Mh8qcYFaXEef1BEgIgiYzSPLheWIy+YhQHekWY\r
+       1wekigcY33Ddr4AGMwENjriqCDK4JBEhJdXAuNVcd1Wm9XOm31Mbpz842Zqw5LN6z3KOa+ly\r
+       C/n++CxIT02fo5VhJN9Wyz/x0eO0OfsSZuvdvffkpnev5GZJ9cAF114yvJfwzH6QW5iw6tzH\r
+       tdcceuZesWpZId4b3y+yrtZMeHvzJeM/Wxad+z2F+fjv9ZtdRF2XT9s86+fzrxZCx/8wVJ0S\r
+       OaHEUpyRaKjFXFScCABi/HHjrAIAAA==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 29 Jan 2012 05:50:17 -0000\r
+\r
+In the error-handling paths of notmuch_database_open, we call\r
+notmuch_database_close, which "delete"s several objects referenced by\r
+the notmuch_database_t object.  However, some of these pointers may be\r
+uninitialized, resulting in undefined behavior.  Hence, allocate the\r
+notmuch_database_t with talloc_zero to make sure these pointers are\r
+NULL so that "delete"ing them is harmless.\r
+---\r
+ lib/database.cc |    2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/lib/database.cc b/lib/database.cc\r
+index 8103bd9..a6d15a1 100644\r
+--- a/lib/database.cc\r
++++ b/lib/database.cc\r
+@@ -617,7 +617,7 @@ notmuch_database_open (const char *path,\r
+       initialized = 1;\r
+     }\r
+ \r
+-    notmuch = talloc (NULL, notmuch_database_t);\r
++    notmuch = talloc_zero (NULL, notmuch_database_t);\r
+     notmuch->exception_reported = FALSE;\r
+     notmuch->path = talloc_strdup (notmuch, path);\r
+ \r
+-- \r
+1.7.7.3\r
+\r