Re: [PATCH] Allow user to specify ignored directories

diff --git a/77/e2182b87ba20ef2e0f33716716a3dea42e8db1 b/77/e2182b87ba20ef2e0f33716716a3dea42e8db1
new file mode 100644 (file)
index 0000000..cbfbea6
--- /dev/null
+++ b/77/e2182b87ba20ef2e0f33716716a3dea42e8db1
@@ -0,0 +1,92 @@
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 43B9B40D141\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Oct 2010 02:09:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.9\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5\r
+       tests=[BAYES_00=-1.9] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id s1d4--HCKyYT for <notmuch@notmuchmail.org>;\r
+       Wed, 13 Oct 2010 02:09:07 -0700 (PDT)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 603D240D143\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Oct 2010 02:09:07 -0700 (PDT)\r
+Received: from localhost (unknown [192.168.200.4])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id F01E419F33E2;\r
+       Wed, 13 Oct 2010 11:09:05 +0200 (CEST)\r
+X-Virus-Scanned: IMAP AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id 19dnV545cGsO; Wed, 13 Oct 2010 11:09:03 +0200 (CEST)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 0E47919F33D9;\r
+       Wed, 13 Oct 2010 11:09:02 +0200 (CEST)\r
+Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30])\r
+       (Authenticated sender: sojkam1)\r
+       by imap.feld.cvut.cz (Postfix) with ESMTPSA id 195D115C082;\r
+       Wed, 13 Oct 2010 11:09:02 +0200 (CEST)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.72)\r
+       (envelope-from <sojkam1@fel.cvut.cz>)\r
+       id 1P5xKX-0003uj-Fa; Wed, 13 Oct 2010 11:09:01 +0200\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: Andreas Amann <andreas.amann@tyndall.ie>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Allow user to specify ignored directories\r
+In-Reply-To: <ylp7hi23mw8.fsf@tyndall.ie>\r
+References: <ylp7hi23mw8.fsf@tyndall.ie>\r
+User-Agent: Notmuch/0.3.1-83-g6fec75f (http://notmuchmail.org) Emacs/23.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 13 Oct 2010 11:09:01 +0200\r
+Message-ID: <87zkui1mtu.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 13 Oct 2010 09:09:18 -0000\r
+\r
+On Thu, 30 Sep 2010, Andreas Amann wrote:\r
+> Hi list,\r
+> \r
+> this is my first post. I found notmuch a couple of days ago and it works\r
+> great. However I wanted to be able to ignore certain directories (mostly\r
+> .git in my case) when "notmuch new" is running. \r
+> \r
+> With this patch the user can provide a list of directories which are\r
+> ignored during the recursive search for new messages. An "ignore"\r
+> label in the "new" section of the configuration file is added for this\r
+> purpose to enable for example something like\r
+\r
+Hi,\r
+\r
+thanks, the patch seems good to me. See the comment bellow.\r
+\r
+\r
+> @@ -202,7 +219,8 @@ _entries_resemble_maildir (struct dirent **entries, int count)\r
+>  static notmuch_status_t\r
+>  add_files_recursive (notmuch_database_t *notmuch,\r
+>                      const char *path,\r
+> -                    add_files_state_t *state)\r
+> +                    add_files_state_t *state,\r
+> +                     notmuch_config_t *config)\r
+\r
+I would not add additional parameter here. It's IMHO better to add field\r
+"ignored_files" to add_files_state_t similarly as it is done for\r
+new_tags.\r
+\r
+-Michal\r