Re: Bug: emacs 23.2 doesn't like ido-completing-read

diff --git a/d3/14f8f74277140fef8c173e31c18405ff2e00d1 b/d3/14f8f74277140fef8c173e31c18405ff2e00d1
new file mode 100644 (file)
index 0000000..13e8006
--- /dev/null
+++ b/d3/14f8f74277140fef8c173e31c18405ff2e00d1
@@ -0,0 +1,93 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0F85F431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Feb 2012 12:14:28 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2gPqkKPdDa-S for <notmuch@notmuchmail.org>;\r
+       Sat,  4 Feb 2012 12:14:27 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 418DB431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Feb 2012 12:14:27 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id D8C9568055; Sat,  4 Feb 2012 22:14:25 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, David Edmondson <dme@dme.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: Bug: emacs 23.2 doesn't like ido-completing-read\r
+In-Reply-To: <8762fmeq4i.fsf@qmul.ac.uk>\r
+References: <871uqijdy4.fsf@qmul.ac.uk>\r
+       <cun4nvdil63.fsf@hotblack-desiato.hh.sledj.net>\r
+       <87pqe14hjh.fsf@qmul.ac.uk> <8762fmeq4i.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.11+7~gf38bc44 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 04 Feb 2012 22:14:25 +0200\r
+Message-ID: <m2bopefja6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Feb 2012 20:14:28 -0000\r
+\r
+On Sat, 04 Feb 2012 12:31:57 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> \r
+> I hadn't realised before but this also goes wrong if you use the prefix\r
+> argument to mail (eg ctrl-u m). The current code seems to mess up the\r
+> mini-buffer and even closing the buffer does not get out of it.\r
+> \r
+> Changing ido-completing-read read to completing-read seems to fix the\r
+> problem entirely. Since this will affect most debian stable users (*) I\r
+> think we should fix it. The trivial patch below works for me but other solutions\r
+> may be better as they could maintain the benefits of ido-completing-read\r
+> (eg that it shows the possibilities).\r
+>\r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> (*) Perhaps only those who have more than one email address.\r
+> \r
+> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> index 023645e..41f82c2 100644\r
+> --- a/emacs/notmuch-mua.el\r
+> +++ b/emacs/notmuch-mua.el\r
+> @@ -191,7 +191,7 @@ the From: header is already filled in by notmuch."\r
+>      ;; Now prompt the user, either for an email address only or for a full identity.\r
+>      (if one-name-only\r
+>      (let ((address\r
+> -           (ido-completing-read (concat "Sender address for " name ": ") addresses\r
+> +           (completing-read (concat "Sender address for " name ": ") addresses\r
+>                                  nil nil nil 'notmuch-mua-sender-history (car addresses))))\r
+>        (concat name " <" address ">"))\r
+>        (ido-completing-read "Send mail From: " notmuch-identities\r
+\r
+Should that other ido-completing-read be kept there -- it is the only\r
+one left after this patch...\r
+\r
+Tomi\r
+\r
+\r
+> -- \r
+> 1.7.2.3\r
+\r