Re: [notmuch] [PATCH] Add tests to configure script to detect strndup and getline

diff --git a/ad/24b979d40c3249c5a0bfad7465cbbf83326e46 b/ad/24b979d40c3249c5a0bfad7465cbbf83326e46
new file mode 100644 (file)
index 0000000..0a918c7
--- /dev/null
+++ b/ad/24b979d40c3249c5a0bfad7465cbbf83326e46
@@ -0,0 +1,76 @@
+Return-Path: <marten@veldthuis.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 44186431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 14:06:49 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id HfR+TuOWI7xK for <notmuch@notmuchmail.org>;\r
+       Fri, 27 Nov 2009 14:06:48 -0800 (PST)\r
+Received: from mout.perfora.net (mout.perfora.net [74.208.4.195])\r
+       by olra.theworths.org (Postfix) with ESMTP id 67D74431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 14:06:48 -0800 (PST)\r
+Received: from smtp04.online.nl (smtp04.online.nl [194.134.41.34])\r
+       by mx.perfora.net (node=mxus2) with ESMTP (Nemesis)\r
+       id 0LpcRq-1NkkDZ1aje-00fY3H for notmuch@notmuchmail.org;\r
+       Fri, 27 Nov 2009 17:06:47 -0500\r
+Received: from smtp04.online.nl (localhost [127.0.0.1])\r
+       by smtp04.online.nl (Postfix) with ESMTP id AA1BDE098\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 23:06:41 +0100 (CET)\r
+Received: from home.veldthuis.com (s55919504.adsl.wanadoo.nl [85.145.149.4])\r
+       by smtp04.online.nl (Postfix) with ESMTP\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 23:06:41 +0100 (CET)\r
+Received: by home.veldthuis.com (Postfix, from userid 501)\r
+       id 999542DA664; Fri, 27 Nov 2009 23:06:40 +0100 (CET)\r
+Date: Fri, 27 Nov 2009 23:06:40 +0100\r
+From: Marten Veldthuis <marten@veldthuis.com>\r
+To: notmuch@notmuchmail.org\r
+Message-ID: <20091127220640.GA17750@gopher.local>\r
+Mail-Followup-To: notmuch@notmuchmail.org\r
+References: <1258983810-27522-2-git-send-email-jeff@ocjtech.us>\r
+       <1259000055-15068-1-git-send-email-jeff@ocjtech.us>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii; format=flowed\r
+Content-Disposition: inline\r
+In-Reply-To: <1259000055-15068-1-git-send-email-jeff@ocjtech.us>\r
+User-Agent: Mutt/1.5.20 (2009-06-14)\r
+X-Online-Scanned: by Cloudmark authority (on smtp04.online.nl)\r
+Subject: Re: [notmuch] [PATCH] Add tests to configure script to detect\r
+ strndup and getline\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 27 Nov 2009 22:06:49 -0000\r
+\r
+On Mon, Nov 23, 2009 at 12:14:15PM -0600, Jeffrey C. Ollie wrote:\r
+> cat > Makefile.config <<EOF\r
+> prefix = /usr/local\r
+> bash_completion_dir = /etc/bash_completion.d\r
+>-CFLAGS += ${have_valgrind}\r
+>+CFLAGS += ${have_valgrind} ${strndup} ${getline}\r
+> EOF\r
+\r
+This doesn't seem to do much for me, they don't seem to end up in the args \r
+passed to g++. I'm no Makefile wizard, so I got notmuch finally compiling by \r
+simply copy/pasting the ${strndup} and ${getline} from Makefile.config to \r
+Makefile:\r
+\r
+# Now smash together user's values with our extra values\r
+override CFLAGS += $(WARN_FLAGS) $(extra_cflags) -Dstrndup=_notmuch_strndup \r
+-Dgetline=_notmuch_getline\r
+override CXXFLAGS += $(WARN_FLAGS) $(extra_cflags) $(extra_cxxflags) \r
+-Dstrndup=_notmuch_strndup -Dgetline=_notmuch_getline\r
+\r
+-- \r
+- Marten\r