Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for...

diff --git a/f9/45451eaacb126e4430b748526fac1af973927c b/f9/45451eaacb126e4430b748526fac1af973927c
new file mode 100644 (file)
index 0000000..8971762
--- /dev/null
+++ b/f9/45451eaacb126e4430b748526fac1af973927c
@@ -0,0 +1,120 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 02DEE429E25\r
+       for <notmuch@notmuchmail.org>; Tue, 10 Jan 2012 18:56:46 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id JWTRSwoeSg4x for <notmuch@notmuchmail.org>;\r
+       Tue, 10 Jan 2012 18:56:45 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 64F52431FD0\r
+       for <notmuch@notmuchmail.org>; Tue, 10 Jan 2012 18:56:45 -0800 (PST)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id D533A66E014B;\r
+       Tue, 10 Jan 2012 18:56:42 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (gwave-171.ligo.caltech.edu\r
+ [131.215.114.171])    (Authenticated sender: jrollins)        by earth-doxen-submit\r
+ (Postfix) with ESMTP id F2A8766E0115; Tue, 10 Jan 2012 18:56:29 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id DC91C3E7; Tue, 10 Jan 2012 18:56:29 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Aaron Ecay <aaronecay@gmail.com>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal\r
+       function for general thread tagging\r
+In-Reply-To: <m2obudii3n.fsf@gmail.com>\r
+References: <1325975294-646-1-git-send-email-jrollins@finestructure.net>\r
+       <1325975294-646-2-git-send-email-jrollins@finestructure.net>\r
+       <1325975294-646-3-git-send-email-jrollins@finestructure.net>\r
+       <m239bpk7h0.fsf@gmail.com> <87boqdr3mz.fsf@servo.finestructure.net>\r
+       <m2obudii3n.fsf@gmail.com>\r
+User-Agent: Notmuch/0.10.2+168~g34b8bac (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 10 Jan 2012 18:56:29 -0800\r
+Message-ID: <87fwfnne02.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 11 Jan 2012 02:56:46 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon, 09 Jan 2012 00:02:20 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:\r
+> On Sun, 08 Jan 2012 18:49:56 -0800, Jameson Graef Rollins <jrollins@fines=\r
+tructure.net> wrote:\r
+> > On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay <aaronecay@gmail.com> wr=\r
+ote:\r
+> > >\r
+> > > - It would be good to make show-next &optional.  This will enable code\r
+> > >   to call the fn with only two arguments, and not showing next will be\r
+> > >   the default behavior.\r
+> >=20\r
+> > That's a nice idea.  Probably better for a separate patch, though.\r
+>=20\r
+> This patch introduces show-next as a new argument to the function.  So it\r
+> can and should make it &optional, if that is the appropriate semantics\r
+> for it to have.\r
+\r
+Actually, the show-next argument was already part of the function.  I\r
+did not introduce it.  And it wasn't optional originally, so if we want\r
+to change that behavior we should probably do so in a separate patch.\r
+\r
+> That said, here=E2=80=99s an alternate proposal: provide two functions as=\r
+ the\r
+> =E2=80=9Cexternal=E2=80=9D API, namely =E2=80=98notmuch-show-{add,remove}=\r
+-tag-thread=E2=80=99 (by\r
+> parallelism with =E2=80=98notmuch-show-{add,remove}-tag=E2=80=99).  These=\r
+ could be\r
+> thin wrappers around =E2=80=98notmuch-show-tag-thread-internal=E2=80=99, =\r
+which would\r
+> then not be intended to be called by user code.\r
+\r
+I think that's a better idea.  In the next version I'll add something\r
+like this instead.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPDPpdAAoJEO00zqvie6q8L60QAJtv4I4MvMwLqceiWECdcgys\r
+icJ4AUK5VKkL0B4qRZtmMenGvBWmGAGcSnlcvaZWLveO56lnSRU66D9naXNheShn\r
+KPdBdgH2Atq2RofhwyRTik0JO/tlzJ6N9+N0uUjqLcf8mqt3Q2hc+3KpyBT5SuLp\r
+0MmD7zOIoJEKf5q32OWNbw3qIUOVNH0VMbCdm38g01xqPMJPnHGy4xICwMZW273d\r
+tn2/hGUg2J/ZE9jJ5KWXntm2m4xlBYq/GfJ3VsQpg9gN1PmgeMH7HzEj63PAkLbm\r
+A4SVL3tPlKGfKEvWorsTqZJVIqF+tgMNE5YnGz9fyxDr4/AyXl+fjQ2w/hEnXTTQ\r
+98Ldr8Wn0Lq/pEphIKTtAhCorzHC93d6wqo2jd2BK0t18vqhK7o5Q6lr83DHySDR\r
+RZyTN9buRFzfL3lO5M2tB+344a0coYztuOZLWyfJhxcwMbnGonK5mC1OQiqQtLdk\r
+BlY7gdQvB1HXSjYRMssKWWlJyFo/yr313LRe45nbIRoT3fVO4xWXa/0utwKSeHvr\r
+2Irp6OnNd4z37A1DnK9w4uhmd3INktCwmOLDLygsgqOqFDBgesy7IVAgpfAv1rv7\r
+Pl9WrO6dGsGu/qvlFaOP4+KnM/F6DGMJwh+AqpDw7XKNYi0x/yR3CGffcS4YkK8I\r
+0zPtiudex6vs5lU+X2ow\r
+=LlNY\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r