Re: [PATCH v2] emacs: logically group def{custom,face}s

diff --git a/02/761d491a774532d6c04087447f343cb560279d b/02/761d491a774532d6c04087447f343cb560279d
new file mode 100644 (file)
index 0000000..03b72d9
--- /dev/null
+++ b/02/761d491a774532d6c04087447f343cb560279d
@@ -0,0 +1,93 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B1AE6429E38\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 01:04:15 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8TiMetlT2T3G for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Jan 2012 01:04:13 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 993A9431FB6   for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 01:04:13 -0800\r
+ (PST)\r
+Received: by wgbds11 with SMTP id ds11so3530845wgb.2\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 01:04:12 -0800 (PST)\r
+Received: by 10.180.14.161 with SMTP id q1mr2127871wic.1.1326531852317;\r
+       Sat, 14 Jan 2012 01:04:12 -0800 (PST)\r
+Received: from localhost ([109.131.75.86])\r
+       by mx.google.com with ESMTPS id 28sm14164453wby.3.2012.01.14.01.04.11\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sat, 14 Jan 2012 01:04:11 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH v2] emacs: logically group def{custom,face}s\r
+In-Reply-To: <87fwfknuqx.fsf@zancas.localnet>\r
+References: <87bos6tcgp.fsf@zancas.localnet>\r
+       <1326388336-15940-1-git-send-email-pieter@praet.org>\r
+       <87fwfknuqx.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Sat, 14 Jan 2012 10:02:30 +0100\r
+Message-ID: <87ty3ypsgp.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Jan 2012 09:04:15 -0000\r
+\r
+On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner <david@tethera.net> wrote:\r
+> On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > To allow for expansion whilst keeping everything tidy and organized,\r
+> > move all defcustom/defface variables to the following subgroups,\r
+> > defined in notmuch-lib.el:\r
+> > \r
+> > - Hello\r
+> > - Search\r
+> > - Show\r
+> > - Send\r
+> > - Crypto\r
+> > - Hooks\r
+> > - Appearance\r
+> > - External Commands\r
+> \r
+> I didn't investigate too closely, but I noticed when I customize-group\r
+> emacs, each subgroup has some explanatory text beside it. Did you omit\r
+> that on purpose?\r
+> \r
+\r
+That is correct.  Coming up with decent docstrings is hard :)\r
+\r
+Also, the group names are fairly descriptive in and of themselves IMO.\r
+\r
+Anyways, I've given it a shot, but (I hope!) people will come up with\r
+much better descriptions, so this probably isn't the end of it...\r
+\r
+Patch follows.\r
+\r
+> d\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r