Re: [PATCH 3/3] test: add broken roundtrip test

diff --git a/94/5d9351aa74c12ea75b79e1ab2a67deb1ee0878 b/94/5d9351aa74c12ea75b79e1ab2a67deb1ee0878
new file mode 100644 (file)
index 0000000..d2032a0
--- /dev/null
+++ b/94/5d9351aa74c12ea75b79e1ab2a67deb1ee0878
@@ -0,0 +1,120 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7D195431FBD\r
+       for <notmuch@notmuchmail.org>; Wed,  8 Aug 2012 09:33:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Hrvp6f5vJ2bQ for <notmuch@notmuchmail.org>;\r
+       Wed,  8 Aug 2012 09:33:43 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 155FA431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  8 Aug 2012 09:33:43 -0700 (PDT)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 78DF332801B;\r
+       Wed,  8 Aug 2012 09:33:38 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (unknown [76.89.192.57])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id 934382E50766;\r
+       Wed,  8 Aug 2012 09:33:33 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 127905CF; Wed,  8 Aug 2012 09:33:33 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, david@tethera.net,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/3] test: add broken roundtrip test\r
+In-Reply-To: <87zk6524f0.fsf@qmul.ac.uk>\r
+References: <1344190393-22497-1-git-send-email-david@tethera.net>\r
+       <1344190393-22497-4-git-send-email-david@tethera.net>\r
+       <87zk6524f0.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.13.2+137~ge34ed71 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 08 Aug 2012 09:33:30 -0700\r
+Message-ID: <87k3x9ibs5.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 08 Aug 2012 16:33:43 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Wed, Aug 08 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>>  test/dump-restore |    9 +++++++++\r
+>>  1 file changed, 9 insertions(+)\r
+>>\r
+>> diff --git a/test/dump-restore b/test/dump-restore\r
+>> index 439e998..7979ebf 100755\r
+>> --- a/test/dump-restore\r
+>> +++ b/test/dump-restore\r
+>> @@ -82,4 +82,13 @@ test_begin_subtest "dump outfile -- from:cworth"\r
+>>  notmuch dump dump-outfile-dash-inbox.actual -- from:cworth\r
+>>  test_expect_equal_file dump-cworth.expected dump-outfile-dash-inbox.act=\r
+ual\r
+>>=20=20\r
+>> +test_expect_success 'roundtripping random message-ids and tags' \\r
+>> +    'test_subtest_known_broken &&\r
+>> +    ${TEST_DIRECTORY}/random-corpus --config-path=3D${NOTMUCH_CONFIG} &&\r
+>> +    notmuch dump > EXPECTED.$test_count &&\r
+>> +    notmuch tag -random-corpus tag:random-corpus &&\r
+>> +    notmuch restore < EXPECTED.$test_count 2>/dev/null &&\r
+>> +    notmuch dump > OUTPUT.$test_count &&\r
+>> +    test_cmp EXPECTED.$test_count OUTPUT.$test_count 1>/dev/null'\r
+>\r
+> Are the single quotes at the start and end of the main block meant to be\r
+> there? And with them deleted this seems to pass (but there is lots of\r
+> diff if the redirection is removed).  I am not familiar with\r
+> test_expect_success/test_cmp so don't know what to expect.\r
+\r
+I don't understand what's going on here either.  This seems like a\r
+strange way to run these tests, as a command string to\r
+test_expect_success.  Why not just run them directly?\r
+\r
+I'm also worried about the test output blowing away the users terminal.\r
+I think that should be avoided, even if we expect failures to be rare.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJQIpTaAAoJEO00zqvie6q8D/wP/iqcM+7J9Qky+8R80lRob490\r
+larFqaOLdL/veUtXthwOo0ceqefEJ7Sy0FJEsPvDMJiarwE+dsHUL5S5HkRrgzy4\r
+T5/Hqb3HJY8OfuIwNqRKdNrhOLrC2tasP3XqaPqTRAun2igfxdxjjMU/EuWkNDeL\r
+I9KTfH78+bptPg+jdwAnIZ5hnd9SKjmT0CQ9laTYpzFCdB0gFRBhSZ0vIZq7BvV0\r
+c6hytG1IpqCWT+VpRYWGrOybjyZzE/ua3uPBLoSzNmGMV5dQMKF7tYZWe4UX7Fdn\r
+fAgRz5J9ejihDWOzoDLjMVCK7DAPvaJ66Ti2YJFzgM55BsB87rO93ngo8c9Ik1dN\r
+33zoKN5OPsboQ+RlV3VC9tzicbHDk0+fqT/wblsm+wVyTWNSoKK1Rl8yphMSTkBd\r
+VDFcmC7nHrd8oz/uvb+5UP+1FSMBtA5FxJO2VRSVZuyLfZJZAVFr9++Lct3ebxZx\r
+Fj0i40+DujvTWkJYYCS/dv1sQuV+/U19XsYx9MeQ52YVnZHcLegHd/XyvvaH48mB\r
+LkwqVlqQ4W7FZnveqNnzXbXL517YaW9n8UqkdTztRTXeWNuoS8sUn3A3w7o7BM1f\r
+wb90/xb6uP2QOn2DCcM4CiiyuKFE39O8XIDCtVRtQoU0Dfies1Fjc6i+m7MtA/66\r
+8PxH9o2vLTFwm0CWXHZ5\r
+=ubiH\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r