Re: [PATCH 0/9] test: (hopefully) better test prerequisites

diff --git a/90/d858da51126ae126e41f22952ac7fd6d21023f b/90/d858da51126ae126e41f22952ac7fd6d21023f
new file mode 100644 (file)
index 0000000..054dae8
--- /dev/null
+++ b/90/d858da51126ae126e41f22952ac7fd6d21023f
@@ -0,0 +1,105 @@
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 90A32429E28\r
+       for <notmuch@notmuchmail.org>; Thu, 17 Nov 2011 06:03:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id BsjM7AEXGju4 for <notmuch@notmuchmail.org>;\r
+       Thu, 17 Nov 2011 06:03:01 -0800 (PST)\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B885C429E27\r
+       for <notmuch@notmuchmail.org>; Thu, 17 Nov 2011 06:03:00 -0800 (PST)\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+       pAHE2kSG005902; Thu, 17 Nov 2011 16:02:46 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,\r
+       Tomi Ollila <tomi.ollila@iki.fi>,\r
+       Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/9] test: (hopefully) better test prerequisites\r
+In-Reply-To: <8739dmopcu.fsf@gmail.com>\r
+References: <1321494986-18998-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <874ny36rhc.fsf@servo.finestructure.net>\r
+       <yf64ny3gcu4.fsf@taco2.nixu.fi> <8739dmopcu.fsf@gmail.com>\r
+User-Agent: Notmuch/0.9+73~ged20210 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 17 Nov 2011 16:02:46 +0200\r
+Message-ID: <yf6wrayg83d.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 17 Nov 2011 14:03:01 -0000\r
+\r
+On Thu, 17 Nov 2011 17:22:41 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> Hi Tomi.\r
+> \r
+> On Thu, 17 Nov 2011 14:20:19 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> > \r
+> > I.e. dynamically, at run-time, re-create test_emacs function...\r
+> > \r
+> \r
+> Could you please add some human-friendly description on what benefits\r
+> the code above has? :)\r
+\r
+"All problems in computer science can be solved by another level of indirection"\r
+\r
+> The only change I see (besides code refactoring) is 30sec timeout (BTW\r
+> you can replace the list of numbers with "seq 30") instead of infinite\r
+> wait loop.  Which may be a good, but unrelated change.\r
+\r
+Can't do `seq 30` it is not portable. BSD world uses different command.\r
+\r
+> As for re-creating functions dynamically, I find the above code more\r
+> complex than the existing one.  I think the current code is more\r
+> shell-style and easier to understand.  Just IMHO.\r
+\r
+Think it as a function pointer (I should have renamed that as test_emacs_p ;)\r
+\r
+Shell is hyper-dynamic being (like python). New functionality can be\r
+written 'on-the-fly' inside functions (often without eval) Even variables \r
+can be referenced as function names. Hmm, even perl4 has this way of \r
+working supported...\r
+\r
+IMHO it is simpler when one get's used to.\r
+\r
+... just that the test "framework" needs some refactoring... along the\r
+way all of these "practises" should be defined. code style, variable names\r
+consistency, etc...  \r
+\r
+You've done good work with this 'prereq' -thing. It's just hard to see\r
+the elegance here. I know this very well as I have to maintain my\r
+own 'evolutionary' developed code -- when priority is on short-term\r
+cost savings over code consistency..\r
+\r
+> \r
+> Regards,\r
+>   Dmitry\r
+> \r
+> > \r
+> > Tomi\r
+\r
+Tomi\r