Re: [PATCH] Save and restore point explicitly in `notmuch-wash-toggle-invisible-action'.

diff --git a/ac/27bda0133c40a1df1a06844299e76636672391 b/ac/27bda0133c40a1df1a06844299e76636672391
new file mode 100644 (file)
index 0000000..44187d0
--- /dev/null
+++ b/ac/27bda0133c40a1df1a06844299e76636672391
@@ -0,0 +1,85 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 670DB431FD0\r
+       for <notmuch@notmuchmail.org>; Tue, 24 May 2011 15:57:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 26HMLVFZ7Dmp for <notmuch@notmuchmail.org>;\r
+       Tue, 24 May 2011 15:57:40 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id F23E1431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 24 May 2011 15:57:39 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id EFC0B29A482;\r
+       Tue, 24 May 2011 15:57:37 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id DF19A25417E; Tue, 24 May 2011 15:57:37 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Austin Clements <amdragon@mit.edu>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH] Save and restore point explicitly in\r
+       `notmuch-wash-toggle-invisible-action'.\r
+In-Reply-To: <BANLkTi=_PszwPDRbRxVpVhkT=YRAi5dGDQ@mail.gmail.com>\r
+References: <1306090675-26982-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1306164587-20326-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87oc2rlujb.fsf@yoom.home.cworth.org> <8762ozrfrr.fsf@gmail.com>\r
+       <87oc2rvjvj.fsf@yoom.home.cworth.org> <871uznrbh5.fsf@gmail.com>\r
+       <BANLkTi=_PszwPDRbRxVpVhkT=YRAi5dGDQ@mail.gmail.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Tue, 24 May 2011 15:57:32 -0700\r
+Message-ID: <87fwo3btb7.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 24 May 2011 22:57:40 -0000\r
+\r
+--=-=-=\r
+\r
+On Tue, 24 May 2011 18:43:41 -0400, Austin Clements <amdragon@mit.edu> wrote:\r
+> Saving point this way is a bit dangerous, though.  For example, if\r
+> you're near the end of the buffer and shorten the label, attempting to\r
+> restore the point could result in an error (or, a more benign example:\r
+> the cursor could wind up outside the label so pressing RET repeatedly\r
+> won't toggle it).\r
+\r
+Without the patch to change save-excursion to an integer, point is\r
+already moving outside the button, (so that repeatedly pressing RET\r
+doesn't toggle).\r
+\r
+I'm exploring a proper fix now to get reliable behavior.\r
+\r
+-Carl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk3cN9wACgkQ6JDdNq8qSWg0IACgoMLhCretCpHFc85vRwuJiDw3\r
+CggAn3CIKV/iHpqQ2VggjeaTgn58AEka\r
+=Q5Ni\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r