Re: [PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

diff --git a/d2/b0d02b9fcf5c8376a95e6e5b4e448c104a394b b/d2/b0d02b9fcf5c8376a95e6e5b4e448c104a394b
new file mode 100644 (file)
index 0000000..bf80025
--- /dev/null
+++ b/d2/b0d02b9fcf5c8376a95e6e5b4e448c104a394b
@@ -0,0 +1,98 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0D6A2431FC3\r
+       for <notmuch@notmuchmail.org>; Thu, 24 May 2012 14:57:13 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1Ab7u5tXQk90 for <notmuch@notmuchmail.org>;\r
+       Thu, 24 May 2012 14:57:09 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
+       [18.7.68.35])\r
+       by olra.theworths.org (Postfix) with ESMTP id EFB7A431FBD\r
+       for <notmuch@notmuchmail.org>; Thu, 24 May 2012 14:57:08 -0700 (PDT)\r
+X-AuditID: 12074423-b7fcc6d0000008a8-05-4fbeaeb44e96\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 8A.77.02216.4BEAEBF4; Thu, 24 May 2012 17:57:08 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q4OLv8i9016228; \r
+       Thu, 24 May 2012 17:57:08 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4OLv7hT008328\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Thu, 24 May 2012 17:57:08 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SXg1r-0006DG-19; Thu, 24 May 2012 17:57:07 -0400\r
+Date: Thu, 24 May 2012 17:57:06 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH v3 3/4] new: Merge error checks from add_files and\r
+       add_files_recursive\r
+Message-ID: <20120524215706.GA11804@mit.edu>\r
+References: <1336429240-1114-1-git-send-email-amdragon@mit.edu>\r
+       <1337887922-13163-1-git-send-email-amdragon@mit.edu>\r
+       <1337887922-13163-4-git-send-email-amdragon@mit.edu>\r
+       <87wr415mc3.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87wr415mc3.fsf@nikula.org>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hRV1t2ybp+/wc+7yhZN050trt+cyezA\r
+       5HHr/mt2j2erbjEHMEVx2aSk5mSWpRbp2yVwZdw7cYS5YClrxdlDs1kbGPtYuhg5OSQETCQm\r
+       3N8LZYtJXLi3nq2LkYtDSGAfo8SdJy2sEM4GRokDuztZIJyTTBKtc54xQThLGCWOHOwHynBw\r
+       sAioSsxo8gYZxSagIbFt/3JGEFtEQFFi88n9YDazgLTEt9/NTCC2sECMxJJHZ9hAbF4BHYme\r
+       62+hZp5mlLjV3coOkRCUODnzCQtEs5bEjX8vmUB2gQxa/o8DJMwJtGvt9G1gM0UFVCSmnNzG\r
+       NoFRaBaS7llIumchdC9gZF7FKJuSW6Wbm5iZU5yarFucnJiXl1qka6aXm1mil5pSuokRFNbs\r
+       Lso7GP8cVDrEKMDBqMTDyxi9z1+INbGsuDL3EKMkB5OSKO+P1UAhvqT8lMqMxOKM+KLSnNTi\r
+       Q4wSHMxKIryCkUA53pTEyqrUonyYlDQHi5I471rN3f5CAumJJanZqakFqUUwWRkODiUJXn5g\r
+       /AoJFqWmp1akZeaUIKSZODhBhvMADWcCqeEtLkjMLc5Mh8ifYlSUEuf9uBYoIQCSyCjNg+uF\r
+       pZ1XjOJArwjzsoO08wBTFlz3K6DBTECDtzzeCzK4JBEhJdXA6LSt+h3HjcLVIcZq6S6urie/\r
+       +MwKm3OBKy/ksqzfwbTm9M7WJsZTrFYWqytkRV62L/CQ+y77/ULQ74ldPstcBSYYTNy3Qvbg\r
+       Sbu0y6vvWZUF6xZs0P8/R+J/9bOEPeGTt76be3f3tod/Z9sdkQ4LYb0SeG62/ofPLDrz+j/2\r
+       7bu5oedn+yP9BiWW4oxEQy3mouJEAB0G0H8WAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 24 May 2012 21:57:13 -0000\r
+\r
+Quoth Jani Nikula on May 24 at 11:57 pm:\r
+> On Thu, 24 May 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > Before XXX, add_files_recursive could have been called on a symlink to\r
+> > a non-directory.  Hence, calling it on a non-directory was not an\r
+> > error, so a separate function, add_files, existed to fail loudly in\r
+> > situations where the path had to be a directory.\r
+> \r
+> "Before XXX"?\r
+\r
+Arg.  I meant to replace that with a commit ID, but now I don't\r
+remember what commit I wanted to reference.\r
+\r
+> Otherwise, this 3/4 and following 4/4 patch LGTM. I didn't bother\r
+> looking at 1/4 and 2/4 again, as you say there were no changes.\r
+> \r
+> \r
+> BR,\r
+> Jani.\r