Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

diff --git a/f9/23c52414b415e9413594276ea5f129a7ffd06e b/f9/23c52414b415e9413594276ea5f129a7ffd06e
new file mode 100644 (file)
index 0000000..99492ff
--- /dev/null
+++ b/f9/23c52414b415e9413594276ea5f129a7ffd06e
@@ -0,0 +1,100 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2E1F8431FDA\r
+       for <notmuch@notmuchmail.org>; Tue, 24 Jan 2012 10:47:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id boY-9j+QlTKx for <notmuch@notmuchmail.org>;\r
+       Tue, 24 Jan 2012 10:47:12 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 91739431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 24 Jan 2012 10:47:12 -0800 (PST)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id E2818328063;\r
+       Tue, 24 Jan 2012 10:47:07 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (DHCP-123-180.caltech.edu [131.215.123.180])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id 92BB132803F;\r
+       Tue, 24 Jan 2012 10:47:00 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 702172CE; Tue, 24 Jan 2012 10:47:00 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] emacs: Don't return the button from\r
+       `notmuch-show-insert-part-header'.\r
+In-Reply-To: <1327409620-10133-2-git-send-email-dme@dme.org>\r
+References: <1327052612-1040-1-git-send-email-dme@dme.org>\r
+       <1327409620-10133-1-git-send-email-dme@dme.org>\r
+       <1327409620-10133-2-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.11+102~g958863a (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 24 Jan 2012 10:46:57 -0800\r
+Message-ID: <87k44hym3i.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 24 Jan 2012 18:47:13 -0000\r
+\r
+--=-=-=\r
+\r
+On Tue, 24 Jan 2012 12:53:38 +0000, David Edmondson <dme@dme.org> wrote:\r
+> Instead, allow the caller to specify some parameters for the\r
+> button. Rework `notmuch-show-insert-part-multipart/signed' and\r
+> `notmuch-show-insert-part-multipart/encrypted' accordingly.\r
+\r
+Hi, David.  I was thinking about this, and it seems to me that returning\r
+the button itself is useful.  I can imagine in the future that it might\r
+be useful to be able to modify the button after you've created.  Maybe\r
+it's inconvenient to specify all button parameters at creation time.\r
+\r
+Is there a reason it's really necessary to make this change?  Can't\r
+callers just ignore the returned button if they don't care about it\r
+further?  I can see that maybe it's nice to be able to specify\r
+parameters at creation time, but I'm not sure why that requires throwing\r
+out the returned object as well.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPHvyhAAoJEO00zqvie6q82G4P/2W+cnT/r8F4LCQbwj5x2jHH\r
+8+6ZYI+/hqN0P130YfN6eP/g8tWyI9JUUmTda89cdyiTuka7kiD7IBNEl232cWPH\r
+UIbZGLS+otaSIz5X978jENSfwaXVn4l7R56u20b7X0MLv+EH2GE3oZZTI6oufS2k\r
+Abv6mK/BcfUrjwsswoUSGOUAP801H45eWnxWkHoYSmR28amMNlzw8dD+ql/BReX/\r
+r2lRy0dVPRQ6a42MNKoIqivmWnVXanWffSVr/lTGnbgOCaa19uchqJXl1nSl6g4M\r
+OLVfJF5awm4Abeb//XkvRSkYkQnRlmIpnhTHbx52m2LiL7W+ggAJM2Gx2QRDAxXa\r
+5J+hWVBOC3QJWxiaJG1cEMmekM0R6USGsHPgcU2YIEoLYeppMUeLTdNF0mN50Er2\r
+nkNajTcPzA7zqP0aynAJQWjQsIyt62EkE2coga/z0LJew8xtuwfYsbGEpyxMeGaL\r
+ikHRRKp5qdo+fGUM6T+qyNp4mSonVPTtyD1w7hnyykax2u9V5tzOCCHVVrGT37qb\r
+ddJbBy/J1ueMm0FExHWAeM7xegSxJ5PhV/jjYL0vnFyW07A4QJIt5VAjeN++NmQ7\r
+exqbvs8Q0wwpbYfASr81CDtHnAOK2GISlIPZ1PvgaXE9IajmYIxLDb0ugfgvWFWW\r
+FEC5oc12qGLMcb9DjcNb\r
+=g7Xa\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r