Re: [PATCH 3/3] emacs: do not call notmuch show for non-inlinable parts

diff --git a/cd/5949ac49dc315e7d4418532d8b9ff2de93f5ca b/cd/5949ac49dc315e7d4418532d8b9ff2de93f5ca
new file mode 100644 (file)
index 0000000..dc5d563
--- /dev/null
+++ b/cd/5949ac49dc315e7d4418532d8b9ff2de93f5ca
@@ -0,0 +1,101 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 05076429E25\r
+       for <notmuch@notmuchmail.org>; Sun, 27 Nov 2011 18:52:56 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 7ec3o2bG15OL for <notmuch@notmuchmail.org>;\r
+       Sun, 27 Nov 2011 18:52:55 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
+       [18.7.68.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6D105431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 27 Nov 2011 18:52:55 -0800 (PST)\r
+X-AuditID: 12074424-b7ef76d0000008dc-94-4ed2f78774bd\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 7B.95.02268.787F2DE4; Sun, 27 Nov 2011 21:52:55 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id pAS2qs0t008516; \r
+       Sun, 27 Nov 2011 21:52:55 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pAS2qrTC024647\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sun, 27 Nov 2011 21:52:54 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1RUrMx-0000Rz-TZ; Sun, 27 Nov 2011 21:54:59 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/3] emacs: do not call notmuch show for non-inlinable\r
+       parts\r
+In-Reply-To: <1322271878-32614-3-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1322271878-32614-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1322271878-32614-3-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Notmuch/0.9+77~gfdb7dac (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Sun, 27 Nov 2011 21:54:59 -0500\r
+Message-ID: <87d3cd2by4.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFnrEIsWRmVeSWpSXmKPExsUixG6notv+/ZKfwe7jbBZXt/azW1y/OZPZ\r
+       gclj56y77B7PVt1iDmCK4rJJSc3JLEst0rdL4Mr4few2c0ETZ8WhA49ZGxhXs3cxcnJICJhI\r
+       PJq2jxHCFpO4cG89WxcjF4eQwD5GiWcv7zFBOBsYJQ72fWeBcE4ySfQuWsIM4SxhlLj5aiIT\r
+       SD+bgIbEtv3LwWaJCHhJfLrewQxiCwsESOz/fxqom4ODU8BbYsesQojeTkaJi8vfg9WLCsRK\r
+       vJ09EayeRUBVYsnUn2wgNi/QfcfOH4ayBSVOznzCAmIzC2hJ3Pj3kmkCo8AsJKlZSFILGJlW\r
+       Mcqm5Fbp5iZm5hSnJusWJyfm5aUW6Zrr5WaW6KWmlG5iBAeli8oOxuZDSocYBTgYlXh4N1y+\r
+       5CfEmlhWXJl7iFGSg0lJlNf4G1CILyk/pTIjsTgjvqg0J7X4EKMEB7OSCG/PUaAcb0piZVVq\r
+       UT5MSpqDRUmc12ang5+QQHpiSWp2ampBahFMVoaDQ0mC9ynIUMGi1PTUirTMnBKENBMHJ8hw\r
+       HqDhsSA1vMUFibnFmekQ+VOMilLivO9AEgIgiYzSPLheWNJ4xSgO9Iow7zWQKh5gwoHrfgU0\r
+       mAloMMfMCyCDSxIRUlINjNOFV6U0dURtdH6tWlCspP1ftWYCT80UlcPsqz99X7zXLMRK9sSc\r
+       /es17hpf/jH/++4/bGXCVRyZ615seD3rVt/zafolMwS4Dx8+enfFKb37V42eLGvN+JBUNK9M\r
+       O7TvcipzuLHQ5G+6f3b6/NsfdjLj+Y2HIrqHmfcemXXdPHaR69NGtd+ec+cqsRRnJBpqMRcV\r
+       JwIAsVVhOPUCAAA=\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 28 Nov 2011 02:52:56 -0000\r
+\r
+LGTM.  We should probably be paying attention to the content\r
+disposition, but this is a definite improvement on what we do now.\r
+\r
+As an interesting side-note, this lets us inline a handful of types that\r
+we previously wouldn't, like application/emacs-lisp.\r
+\r
+On Sat, 26 Nov 2011 05:44:38 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> Before the change, there was a workaround to avoid notmuch show calls\r
+> for parts with application/* Content-Type.  But non-inlinable parts\r
+> are not limited to this Content-Type (e.g. mp3 files have audio/mpeg\r
+> Content-Type and are not inlinable).  For such parts\r
+> `notmuch-show-insert-part-*/*' handler is called which unconditionally\r
+> fetches contents for all parts.\r
+> \r
+> The patch moves content fetching from `notmuch-show-insert-part-*/*'\r
+> to `notmuch-show-mm-display-part-inline' function after MIME inlinable\r
+> checks are done to avoid useless notmuch show calls.  The\r
+> application/* hack is no longer needed and removed.\r
+> ---\r
+>  emacs/notmuch-show.el |   17 +++++------------\r
+>  test/emacs            |    1 -\r
+>  2 files changed, 5 insertions(+), 13 deletions(-)\r
+\r
+Yay!\r