Re: [PATCH v1 0/3] emacs: Allow saving of threads and messages

diff --git a/6f/0d74f3ad7b94482ed15acf1d963c30e4505b40 b/6f/0d74f3ad7b94482ed15acf1d963c30e4505b40
new file mode 100644 (file)
index 0000000..06fb55f
--- /dev/null
+++ b/6f/0d74f3ad7b94482ed15acf1d963c30e4505b40
@@ -0,0 +1,121 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0B035431FBF\r
+       for <notmuch@notmuchmail.org>; Fri,  9 May 2014 05:05:22 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.502\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nnUN8BsD+uiN for <notmuch@notmuchmail.org>;\r
+       Fri,  9 May 2014 05:05:14 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1B9E7431FBC\r
+       for <notmuch@notmuchmail.org>; Fri,  9 May 2014 05:05:14 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1WijY6-0005Nw-3D; Fri, 09 May 2014 13:05:12 +0100\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1WijY5-0001Ey-Oz; Fri, 09 May 2014 13:05:09 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v1 0/3] emacs: Allow saving of threads and messages\r
+In-Reply-To: <1399623743-30478-1-git-send-email-dme@dme.org>\r
+References: <1399623743-30478-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 09 May 2014 13:05:09 +0100\r
+Message-ID: <877g5vb1je.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+       this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: f6657b2bef40f4b75c5d63e6c2fb2dda (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.1 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 09 May 2014 12:05:22 -0000\r
+\r
+\r
+Hi\r
+\r
+I think the functionality is well worth having ("|" cat - > a-file is\r
+ugly!). However, I am not sure about this approach.\r
+\r
+The first two patches are fine, although I think I like constructing a\r
+query then quoting rather than quoting bits of a query and bolting them\r
+together (even the both work).\r
+\r
+My concern is that the current approach gives the user no warning if\r
+they are about to overwrite an existing file, and that this is true\r
+regardless of any emacs settings. \r
+\r
+Could we do these saves by loading into a temporary buffer and then\r
+using the normal emacs save buffer functions? That way we get the\r
+benefit of emacs's normal query-overwrite, and respect any user\r
+customizations of that.\r
+\r
+The only potential problem is to make sure we don't do any accidental\r
+charset conversion. I guess this functionality is probably easy to test\r
+at least!\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+On Fri, 09 May 2014, David Edmondson <dme@dme.org> wrote:\r
+> emacs: Allow saving of threads and messages\r
+>\r
+> Similar to the pipe (|) support, allow saving of threads and messages.\r
+>\r
+>\r
+> David Edmondson (3):\r
+>   emacs: Fix indentation.\r
+>   emacs: Minor re-work of `notmuch-show-pipe-message'\r
+>   emacs: Add `notmuch-show-save-message' to save messages\r
+>\r
+>  emacs/notmuch-show.el | 161 ++++++++++++++++++++++++++++----------------------\r
+>  1 file changed, 91 insertions(+), 70 deletions(-)\r
+>\r
+> -- \r
+> 2.0.0.rc0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r