Re: [PATCH] lib: make find_message{,by_filename) report errors

diff --git a/4c/7878435972fbdd9b7eadbd8d10f2ec7747959f b/4c/7878435972fbdd9b7eadbd8d10f2ec7747959f
new file mode 100644 (file)
index 0000000..dd90879
--- /dev/null
+++ b/4c/7878435972fbdd9b7eadbd8d10f2ec7747959f
@@ -0,0 +1,89 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5B84E429E21\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Oct 2011 18:11:05 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1mRBjvDxpIP2 for <notmuch@notmuchmail.org>;\r
+       Mon,  3 Oct 2011 18:11:04 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AAB61431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Oct 2011 18:11:04 -0700 (PDT)\r
+Received: from zancas.localnet\r
+       (fctnnbsc36w-156034064058.pppoe-dynamic.High-Speed.nb.bellaliant.net\r
+       [156.34.64.58]) (authenticated bits=0)\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p941AwDX015922\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);\r
+       Mon, 3 Oct 2011 22:10:59 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.76)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1RAtX8-0001wc-Gg; Mon, 03 Oct 2011 22:10:58 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Ali Polatel <polatel@gmail.com>, Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH] lib: make find_message{,by_filename) report errors\r
+In-Reply-To: <cover.1317456435.git.alip@exherbo.org>\r
+References: <20110930064712.GA30012@hayalet>\r
+       <cover.1317456435.git.alip@exherbo.org>\r
+User-Agent: Notmuch/0.9~rc1 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 03 Oct 2011 22:10:58 -0300\r
+Message-ID: <8739f9muhp.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: Notmuch Mailing List <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Oct 2011 01:11:05 -0000\r
+\r
+On Sat,  1 Oct 2011 11:12:23 +0300, Ali Polatel <polatel@gmail.com> wrote:\r
+> From: Ali Polatel <alip@exherbo.org>\r
+>=20\r
+> Looks like the patch did not make it correctly the first time.\r
+> Resending using git-send-email=E2=84=A2\r
+>=20\r
+> You may also find the commit in my notmuch repository:\r
+> git://github.com/alip/notmuch.git branch: find_message\r
+\r
+\r
+Hi Ali;\r
+\r
+Thanks for reworking this patch. I looked at branch find_message-v2\r
+in your repo. I have a few comments.\r
+\r
+- In the comments for _resolve_message_id_to_thread_id I guess thread_id\r
+  should be thread_id_ret?\r
+\r
+- in notmuch_database_find_message_by_file_name, I'm not sure why you\r
+  set status to NOTMUCH_STATUS_OUT_OF_MEMORY in the catch block. Is this\r
+  a typo?\r
+\r
+- after the DONE: label of the same routine, how is *message_ret destroyed?\r
+  does it need to wait until the talloc context "notmuch" is freed?\r
+\r
+- I don't really get the change of user to caller around notmuch.h:286\r
+  It is not a big deal, but I guess we should try to be consistent.\r
+\r
+David\r
+\r
+=20\r