Re: bug report: notmuch-hello 'All tags' view

diff --git a/4b/fecf126a849cbfc00c97500dab383ee296136c b/4b/fecf126a849cbfc00c97500dab383ee296136c
new file mode 100644 (file)
index 0000000..80c656c
--- /dev/null
+++ b/4b/fecf126a849cbfc00c97500dab383ee296136c
@@ -0,0 +1,106 @@
+Return-Path: <darren@fernseed.info>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id ADD6040DAC4\r
+       for <notmuch@notmuchmail.org>; Wed,  3 Nov 2010 13:45:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 3.459\r
+X-Spam-Level: ***\r
+X-Spam-Status: No, score=3.459 tagged_above=-999 required=5\r
+       tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,\r
+       DKIM_VALID_AU=-0.1, FH_HOST_IN_ADDRARPA=2.157, RCVD_IN_RP_RNBL=1.31,\r
+       RDNS_DYNAMIC=0.982, TO_NO_BRKTS_DYNIP=1, T_MIME_NO_TEXT=0.01]\r
+       autolearn=no\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id k74EoGVFm9wD for <notmuch@notmuchmail.org>;\r
+       Wed,  3 Nov 2010 13:45:32 -0700 (PDT)\r
+Received: from silentio.fernseed.info (202.4.169.217.in-addr.arpa\r
+       [217.169.4.202])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 83C304196F0\r
+       for <notmuch@notmuchmail.org>; Wed,  3 Nov 2010 13:45:32 -0700 (PDT)\r
+Received: from localhost (bookbinder.fernseed.info\r
+       [IPv6:2001:8b0:ff94:1:224:2cff:fe37:838b])\r
+       (Authenticated sender: darren)\r
+       by silentio.fernseed.info (Postfix) with ESMTPSA id 7486D90B;\r
+       Wed,  3 Nov 2010 20:45:27 +0000 (GMT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fernseed.info;\r
+       s=default; t=1288817130;\r
+       bh=X/riIxxALijhUzrk0YdfAlKhEae+HpYTPl5aVFVflHE=;\r
+       h=From:To:Subject:In-Reply-To:References:Date:Message-ID:\r
+       MIME-Version:Content-Type;\r
+       b=Q5FbY9koN+gxmJFTKDNq9wNIKuoW3xev+mt5BWf3OsuixAnnZ7OUsJb8acmJ44geb\r
+       Hi8o2tF/b1b9c6ga+MERTdNUaEd7bfemdTmugylMbujZ2Nd4C6s+J4z7ayZrubHYq1\r
+       c2gXky8LEzirfSOdtdyc2shLTJK7SqymnUKr1z+0=\r
+From: Darren McGuicken <mailing-notmuch@fernseed.info>\r
+To: Jameson Rollins <jrollins@finestructure.net>,\r
+       Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org\r
+Subject: Re: bug report: notmuch-hello 'All tags' view\r
+In-Reply-To: <871v73wgvf.fsf@servo.finestructure.net>\r
+References: <87pquogrq7.fsf@yoom.home.cworth.org>\r
+       <87lj5bv7sn.fsf@bookbinder.fernseed.info>\r
+       <87r5f3mqdn.fsf@bookbinder.fernseed.info>\r
+       <87oca7mo90.fsf@bookbinder.fernseed.info>\r
+       <871v73wgvf.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.4 (http://notmuchmail.org) Emacs/23.1.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 03 Nov 2010 20:45:21 +0000\r
+Message-ID: <87iq0em90e.fsf@bookbinder.fernseed.info>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 03 Nov 2010 20:45:44 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Tue, 02 Nov 2010 17:33:08 -0400, Jameson Rollins <jrollins@finestructure=\r
+.net> wrote:\r
+> On Tue, 02 Nov 2010 21:03:55 +0000, Darren McGuicken <mailing-notmuch@fer=\r
+nseed.info> wrote:\r
+> > A call to 'notmuch search-tags' from the command line does indeed\r
+> > return an empty string as the first entry for me[1].\r
+>=20\r
+> fwiw, I don't personally get any empty strings in the output of\r
+> search-tags (with 0.4).  So I don't think it's anything inherent to\r
+> that function.\r
+\r
+Thanks for the confirmation Jamie - I had a potter with my data and sure\r
+enough, a search for 'tag:""' returned one hit.  I was able to use the\r
+emacs interface to remove the empty string tag from the matching message\r
+('-' then return with no parameters).\r
+\r
+So it's probably fair to say that we'll want to handle at least the\r
+empty string scenario as part of our standard tag addition logic since\r
+it can lead to unexpected side effects in searching.\r
+\r
+Do we have any other 'known bad' scenarios in tag addition that we want\r
+to catch before I try my hand at a patch?\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iEYEARECAAYFAkzRyeIACgkQP1ao/7snsT70ewCfTHKbzGBukYFTP1oYbBb2NcYR\r
+1y8An0HNpsVZ5Gy8rcOtp3nCEsJXy6ml\r
+=ZWsO\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r