[Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

diff --git a/4c/f549727d4a6b6102300d994912a09cd3364239 b/4c/f549727d4a6b6102300d994912a09cd3364239
new file mode 100644 (file)
index 0000000..e2a8e74
--- /dev/null
+++ b/4c/f549727d4a6b6102300d994912a09cd3364239
@@ -0,0 +1,119 @@
+Return-Path: <bremner@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8D5E4431FBC\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Dec 2012 15:33:55 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id mLk2w3reXn4T for <notmuch@notmuchmail.org>;\r
+       Sun,  9 Dec 2012 15:33:54 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 34EBE431FDE\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Dec 2012 15:33:53 -0800 (PST)\r
+Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.167.90.129] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@tethera.net>)\r
+       id 1ThqNc-0007TE-2c; Sun, 09 Dec 2012 19:33:52 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@tethera.net>)\r
+       id 1ThqNW-0001Da-K1; Sun, 09 Dec 2012 19:33:46 -0400\r
+From: david@tethera.net\r
+To: notmuch@notmuchmail.org\r
+Subject: [Patch v6 1/6] tag-util: factor out rules for illegal tags,\r
+       use in parse_tag_line\r
+Date: Sun,  9 Dec 2012 19:33:23 -0400\r
+Message-Id: <1355096008-4544-2-git-send-email-david@tethera.net>\r
+X-Mailer: git-send-email 1.7.10.4\r
+In-Reply-To: <1355096008-4544-1-git-send-email-david@tethera.net>\r
+References: <1355096008-4544-1-git-send-email-david@tethera.net>\r
+X-Spam_bar: -\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 09 Dec 2012 23:33:56 -0000\r
+\r
+From: David Bremner <bremner@debian.org>\r
+\r
+This will allow us to be consistent between batch tagging and command\r
+line tagging as far as what is an illegal tag.\r
+---\r
+ tag-util.c |   35 ++++++++++++++++++++++++++++++-----\r
+ 1 file changed, 30 insertions(+), 5 deletions(-)\r
+\r
+diff --git a/tag-util.c b/tag-util.c\r
+index eab482f..c071ea8 100644\r
+--- a/tag-util.c\r
++++ b/tag-util.c\r
+@@ -31,6 +31,29 @@ line_error (tag_parse_status_t status,\r
+     return status;\r
+ }\r
+ \r
++/*\r
++ * Test tags for some forbidden cases.\r
++ *\r
++ * return: NULL if OK,\r
++ *       explanatory message otherwise.\r
++ */\r
++\r
++static const char *\r
++illegal_tag (const char *tag, notmuch_bool_t remove) {\r
++\r
++    if (*tag == '\0' && !remove)\r
++      return "adding empty tag";\r
++\r
++    /* This disallows adding the non-removable tag "-" and\r
++     * enables notmuch tag to take long options more easily.\r
++     */\r
++\r
++    if (*tag == '-' && !remove)\r
++      return  "adding tag starting with -";\r
++\r
++    return NULL;\r
++}\r
++\r
+ tag_parse_status_t\r
+ parse_tag_line (void *ctx, char *line,\r
+               tag_op_flag_t flags,\r
+@@ -95,11 +118,13 @@ parse_tag_line (void *ctx, char *line,\r
+       remove = (*tok == '-');\r
+       tag = tok + 1;\r
+ \r
+-      /* Maybe refuse empty tags. */\r
+-      if (! (flags & TAG_FLAG_BE_GENEROUS) && *tag == '\0') {\r
+-          ret = line_error (TAG_PARSE_INVALID, line_for_error,\r
+-                            "empty tag");\r
+-          goto DONE;\r
++      /* Maybe refuse illegal tags. */\r
++      if (! (flags & TAG_FLAG_BE_GENEROUS)) {\r
++          const char *msg = illegal_tag (tag, remove);\r
++          if (msg) {\r
++              ret = line_error (TAG_PARSE_INVALID, line_for_error, msg);\r
++              goto DONE;\r
++          }\r
+       }\r
+ \r
+       /* Decode tag. */\r
+-- \r
+1.7.10.4\r
+\r