Re: [PATCH 1/4] search: rename auto_exclude_tags to {search, }exclude_tags

diff --git a/55/d70b05468e04050b99e113eee69f585fa1cde0 b/55/d70b05468e04050b99e113eee69f585fa1cde0
new file mode 100644 (file)
index 0000000..ef8b80a
--- /dev/null
+++ b/55/d70b05468e04050b99e113eee69f585fa1cde0
@@ -0,0 +1,97 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id DE4DB431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:16:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id OaG6rXScU-lp for <notmuch@notmuchmail.org>;\r
+       Thu, 19 Jan 2012 13:16:27 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 3CF04431FAE   for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:16:27 -0800\r
+ (PST)\r
+Received: by wgbdt12 with SMTP id dt12so395549wgb.2\r
+       for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:16:24 -0800 (PST)\r
+Received: by 10.180.24.105 with SMTP id t9mr47056386wif.19.1327007784833;\r
+       Thu, 19 Jan 2012 13:16:24 -0800 (PST)\r
+Received: from localhost ([109.131.97.13])\r
+       by mx.google.com with ESMTPS id g12sm1886220wiw.10.2012.01.19.13.16.23\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 19 Jan 2012 13:16:24 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 1/4] search: rename auto_exclude_tags to {search,\r
+       }exclude_tags\r
+In-Reply-To: <20120119194115.GO16740@mit.edu>\r
+References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>\r
+       <1327000744-25463-1-git-send-email-pieter@praet.org>\r
+       <1327000744-25463-2-git-send-email-pieter@praet.org>\r
+       <20120119194115.GO16740@mit.edu>\r
+User-Agent: Notmuch/0.11+99~gab86e73 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Thu, 19 Jan 2012 22:14:33 +0100\r
+Message-ID: <87bopzo0na.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 19 Jan 2012 21:16:28 -0000\r
+\r
+On Thu, 19 Jan 2012 14:41:15 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Quoth Pieter Praet on Jan 19 at  8:19 pm:\r
+> > All other config-related functions and args include the section\r
+> > title in their name, so for the sake of consistency, mirror that.\r
+> > \r
+> > Also, the "auto"matic part is a given, so that was dropped.\r
+> \r
+> LGTM other than one nit, below.\r
+> \r
+> > --- a/notmuch-config.c\r
+> > +++ b/notmuch-config.c\r
+> > @@ -89,9 +89,9 @@ static const char search_config_comment[] =\r
+> >      "\n"\r
+> >      " The following option is supported here:\n"\r
+> >      "\n"\r
+> > -    "\tauto_exclude_tags      A ;-separated list of tags that will be\n"\r
+> > -    "\t excluded from search results by default.  Using an excluded tag\n"\r
+> > -    "\t in a query will override that exclusion.\n";\r
+> > +    "\texclude_tags      A list (separated by ';') of the tags that will be\n"\r
+> > +    "\t\texcluded from search results by default.  Using an excluded tag in a\n"\r
+> > +    "\t\tquery will override that exclusion.\n";\r
+> \r
+> I'd propose that any tag whose name is more than seven characters long\r
+> should have its description start under it, indented by a tab, like I\r
+> did in id:"1326920205-31296-1-git-send-email-amdragon@mit.edu".  That\r
+> looks nice and keeps the description indented consistently without\r
+> ridiculous amounts of negative space and narrow wrapping.\r
+\r
+Oh, nice.  Looks like I should first work down to inbox zero\r
+(still got a looong way to go :/...) before submitting patches.\r
+\r
+I'll wait for yours to be pushed before resubmitting this series.\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r