Re: [WIP PATCH] debugging gmime-2.6 fail.

diff --git a/07/f71ba9f13bb50c597f94e5b4e7c5b6ab6f1681 b/07/f71ba9f13bb50c597f94e5b4e7c5b6ab6f1681
new file mode 100644 (file)
index 0000000..fa1dcaf
--- /dev/null
+++ b/07/f71ba9f13bb50c597f94e5b4e7c5b6ab6f1681
@@ -0,0 +1,106 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 97330431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Mar 2012 10:09:12 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2HS+lyYm4CwL for <notmuch@notmuchmail.org>;\r
+       Thu,  8 Mar 2012 10:09:11 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 200C1431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 Mar 2012 10:09:11 -0800 (PST)\r
+Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.166.230.117] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1S5hlx-0006Hv-UM; Thu, 08 Mar 2012 14:09:10 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1S5hlX-0002ZG-KQ; Thu, 08 Mar 2012 14:08:39 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [WIP PATCH] debugging gmime-2.6 fail.\r
+In-Reply-To: <1331220935-6553-1-git-send-email-david@tethera.net>\r
+References: <87wr6xmlml.fsf@zancas.localnet>\r
+       <1331220935-6553-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.11.1+266~g2432425 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 08 Mar 2012 14:08:39 -0400\r
+Message-ID: <87eht3m0d4.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/mixed; boundary="=-=-="\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 Mar 2012 18:09:12 -0000\r
+\r
+--=-=-=\r
+\r
+On Thu,  8 Mar 2012 11:35:35 -0400, David Bremner <david@tethera.net> wrote:\r
+\r
+\r
+> I ran out of time for the moment, but the following patch gets me down from \r
+> 4196 failures on the notmuch mailing list to 3422.\r
+\r
+That patch is of course complete nonsense. Attached is another silly\r
+patch, which at least demonstrates the problem. With the attached patch,\r
+notmuch (+ gmime-2.6) only fails for non-mbox messages. So I guess we\r
+need a way to detect if a file is mbox before parsing? or a way to get\r
+gmime to be less strict here?\r
+\r
+\r
+--=-=-=\r
+Content-Type: text/x-diff\r
+Content-Disposition: inline;\r
+ filename=0001-WIP-debugging-gmime-2.6-problems.patch\r
+\r
+>From 7fb942049ae68e09ebb9fbca40048f95543ab4b8 Mon Sep 17 00:00:00 2001\r
+From: David Bremner <bremner@debian.org>\r
+Date: Thu, 8 Mar 2012 11:11:21 -0400\r
+Subject: [PATCH] WIP debugging gmime-2.6 problems\r
+\r
+Unconditionally tell gmime to look for an mbox. This of course makes\r
+it fail for non-mboxes.\r
+---\r
+ mime-node.c |    2 ++\r
+ 1 files changed, 2 insertions(+), 0 deletions(-)\r
+\r
+diff --git a/mime-node.c b/mime-node.c\r
+index a95bdab..3e07fbf 100644\r
+--- a/mime-node.c\r
++++ b/mime-node.c\r
+@@ -111,7 +111,9 @@ mime_node_open (const void *ctx, notmuch_message_t *message,\r
+       goto DONE;\r
+     }\r
+ \r
++    g_mime_parser_set_scan_from(mctx->parser, TRUE);\r
+     mctx->mime_message = g_mime_parser_construct_message (mctx->parser);\r
++\r
+     if (!mctx->mime_message) {\r
+       fprintf (stderr, "Failed to parse %s\n", filename);\r
+       status = NOTMUCH_STATUS_FILE_ERROR;\r
+-- \r
+1.7.9.1\r
+\r
+\r
+--=-=-=--\r