Re: [PATCH] Add strcasestr v.3 - add compat implementation of strcasestr
authorCarl Worth <cworth@cworth.org>
Wed, 14 Apr 2010 18:41:42 +0000 (11:41 +1700)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:36:39 +0000 (09:36 -0800)
ae/724a1afec2f3b9614068e38a5d90735e8a77ca [new file with mode: 0644]

diff --git a/ae/724a1afec2f3b9614068e38a5d90735e8a77ca b/ae/724a1afec2f3b9614068e38a5d90735e8a77ca
new file mode 100644 (file)
index 0000000..c16ff14
--- /dev/null
@@ -0,0 +1,100 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1AD0A4196F2\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Apr 2010 11:41:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.89\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id vvug4gcGHly2; Wed, 14 Apr 2010 11:41:43 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 31569431FC1;\r
+       Wed, 14 Apr 2010 11:41:43 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id D1A38568DE1; Wed, 14 Apr 2010 11:41:42 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dirk Hohndel <hohndel@infradead.org>, Tomas Carnecky <tom@dbservice.com>,\r
+       Dirk Hohndel <hohndel@x200.gr8dns.org>\r
+Subject: Re: [PATCH] Add strcasestr v.3 - add compat implementation of\r
+       strcasestr\r
+In-Reply-To: <m3mxx7azkb.fsf@x200.gr8dns.org>\r
+References: <m3vdbvb8p7.fsf@x200.gr8dns.org> <4BC4BC26.1060803@dbservice.com>\r
+       <m3mxx7azkb.fsf@x200.gr8dns.org>\r
+Date: Wed, 14 Apr 2010 11:41:42 -0700\r
+Message-ID: <87pr21g9ll.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 14 Apr 2010 18:41:44 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Tue, 13 Apr 2010 13:05:08 -0700, Dirk Hohndel <hohndel@infradead.org> wr=\r
+ote:\r
+> On Tue, 13 Apr 2010 20:47:02 +0200, Tomas Carnecky <tom@dbservice.com> wr=\r
+ote:\r
+> > On 4/13/10 6:47 PM, Dirk Hohndel wrote:\r
+> > > v.3 of this patch, now with the changes to makefiles, configure script\r
+> > > compat.h and all new files that I need\r
+> > > Please test on platforms lacking strcasestr\r
+...\r
+> > Tested-by: Tomas Carnecky <tom@dbservice.com>\r
+>=20\r
+> Thanks Tomas, I really appreciate it.\r
+\r
+Thanks to both Dirk and Thomas for this portability fix.\r
+\r
+I've pushed it now, with a few minor changes:\r
+\r
+  * Delete trailing whitespace\r
+\r
+  * Add include of "compat.h" from strcasestr.c\r
+\r
+  * Use original commit message from Dirk\r
+\r
+Dirk, the commit message you sent with version 1 of the patch was\r
+perfect. When you send followup patches, please leave a good commit\r
+message as the initial content of the email. Then add any explanatory\r
+text, ("v.3 of this patch...", "Please test..."), in the email *after*\r
+the "---" separator (just before the diffstat). That way it won't become\r
+part of the commit message and our indelible history.\r
+\r
+For now, I manually touched things up, but it would be nice to not have\r
+to do that in the future.\r
+\r
+Thanks!\r
+\r
+=2DCarl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFLxgxm6JDdNq8qSWgRApPxAKCEB4AN8ykZ/n3ERkhPnd6Pf3i4ogCfSGXF\r
+FdxsBSuiHfzeTWbS651dLvI=\r
+=uo4t\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r