Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two general...

diff --git a/4c/5d54a46935c2d566b68b5c04b242b481ac5f49 b/4c/5d54a46935c2d566b68b5c04b242b481ac5f49
new file mode 100644 (file)
index 0000000..462df6c
--- /dev/null
+++ b/4c/5d54a46935c2d566b68b5c04b242b481ac5f49
@@ -0,0 +1,105 @@
+Return-Path: <aaronecay@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 14698421197\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 12:10:45 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kyxQgSG1E6wv for <notmuch@notmuchmail.org>;\r
+       Tue, 17 Jan 2012 12:10:44 -0800 (PST)\r
+Received: from mail-qw0-f46.google.com (mail-qw0-f46.google.com\r
+       [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 82DB3421192\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 12:10:44 -0800 (PST)\r
+Received: by qadc10 with SMTP id c10so1216254qad.5\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 12:10:44 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=OkoAYgNPN0kKDcAhIsMKlu7ACzVOCTAvj1s11Mvjquk=;\r
+       b=N+xPBIy2eaOYDlSfzhVG/xQDZsZQXw/zuryWn262v3TMZH9K3xFA7Eb/gRBMMyV/Qx\r
+       oKKSljA0aEnaNp/PImpfbXmjmsZyZVOkDWKhXkzj7iROHGG9ce48q+LO5BnI0RxyC3aQ\r
+       V1/sSZ4sFzuyoHOKmg2tX94RoFjVhtkdWGnGk=\r
+Received: by 10.229.135.9 with SMTP id l9mr6880686qct.66.1326831043956;\r
+       Tue, 17 Jan 2012 12:10:43 -0800 (PST)\r
+Received: from localhost (luw017.wlan.gapsa.upenn.edu. [128.91.230.146])\r
+       by mx.google.com with ESMTPS id m20sm45603617qaj.14.2012.01.17.12.10.42\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Tue, 17 Jan 2012 12:10:43 -0800 (PST)\r
+From: Aaron Ecay <aaronecay@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal\r
+       into two generally useful functions\r
+In-Reply-To: <1326823531-14549-1-git-send-email-jrollins@finestructure.net>\r
+References: <871uqy19yo.fsf@servo.finestructure.net>\r
+       <1326823531-14549-1-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.11+62~ge41b0d3 (http://notmuchmail.org) Emacs/24.0.92.1\r
+       (i386-apple-darwin10.8.0)\r
+Date: Tue, 17 Jan 2012 15:10:40 -0500\r
+Message-ID: <m2d3aiay4f.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Jan 2012 20:10:45 -0000\r
+\r
+On Tue, 17 Jan 2012 10:05:26 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> Brake up notmuch-show-archive-thread-internal into two new functions:\r
+> \r
+> notmuch-show-tag-thread-internal: applies a tag to all messages in\r
+> thread.  If option remove flag is t, tags will be removed instead of\r
+> added.\r
+> \r
+> notmuch-show-next-thread: moves to the next thread in the search\r
+> result.  If given a prefix, will show the next result, otherwise will\r
+> just move to it in the search view.\r
+> \r
+> Two new interactive functions, notmuch-show-{add,remove}-tag-thread,\r
+> are also added.  Together, these provide a better suit of thread\r
+> tagging and navigation tools.\r
+> \r
+> The higher level thread archiving functions are modified to use these\r
+> new functions.\r
+> ---\r
+>  emacs/notmuch-show.el |   33 ++++++++++++++++++++++++++-------\r
+>  1 files changed, 26 insertions(+), 7 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 03c1f6b..3625afd 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1421,12 +1421,29 @@ argument, hide all of the messages."\r
+>    (interactive)\r
+>    (backward-button 1))\r
+>  \r
+> -(defun notmuch-show-archive-thread-internal (show-next)\r
+> -  ;; Remove the tag from the current set of messages.\r
+> +(defun notmuch-show-tag-thread-internal (tag &optional remove)\r
+> +  ;; Add tag to the current set of messages.  If the remove switch is\r
+> +  ;; given, tags will be removed instead of added.\r
+\r
+This should be a docstring instead of a comment.  (This applies equally\r
+to the old version....)\r
+\r
+-- \r
+Aaron Ecay\r