Re: [PATCH v7 2/2] emacs: Tests for user-defined sections

diff --git a/4b/9dd1b68135166c15211f9e284ec7c0823b1de9 b/4b/9dd1b68135166c15211f9e284ec7c0823b1de9
new file mode 100644 (file)
index 0000000..0e33bcd
--- /dev/null
+++ b/4b/9dd1b68135166c15211f9e284ec7c0823b1de9
@@ -0,0 +1,109 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 17A1E431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 14:49:24 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id tTG+WEhRcTK0 for <notmuch@notmuchmail.org>;\r
+       Sat, 28 Jan 2012 14:49:23 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4CD93431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 14:49:23 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so313138bke.26\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 14:49:21 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=USwfWTuF3WvwyKDMIdj4yl2xbuXWN/nC0yCw2VLYIl0=;\r
+       b=jDz7JT7ZfEx2wVh2MGRvO/BGxW57n7BbCeLohf1tpZTWlUYfsCqw8+k8CvzpDM3+xE\r
+       8YRMs8bBH/424iCFVThBlDQH2BaNKPRJX71XPXtsErcbLaVFsNvWl1iARtYqh/PNKuNw\r
+       FOWxlMA4lioKy90lx+nCRDRyQswQcnZSdqcK4=\r
+Received: by 10.205.130.12 with SMTP id hk12mr5654469bkc.56.1327790961812;\r
+       Sat, 28 Jan 2012 14:49:21 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id bw9sm26076852bkb.8.2012.01.28.14.49.20\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sat, 28 Jan 2012 14:49:21 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Daniel Schoepe <daniel@schoepe.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v7 2/2] emacs: Tests for user-defined sections\r
+In-Reply-To: <87ehujqzu6.fsf@schoepe.localhost>\r
+References: <87d3ac8ta9.fsf@schoepe.localhost>\r
+       <1327193689-6011-1-git-send-email-daniel@schoepe.org>\r
+       <1327193689-6011-2-git-send-email-daniel@schoepe.org>\r
+       <87y5sym31d.fsf@gmail.com> <87ehujqzu6.fsf@schoepe.localhost>\r
+User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 29 Jan 2012 02:48:12 +0400\r
+Message-ID: <87ipjv8mvn.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 28 Jan 2012 22:49:24 -0000\r
+\r
+Hi Daniel.\r
+\r
+On Sat, 28 Jan 2012 22:30:57 +0100, Daniel Schoepe <daniel@schoepe.org> wrote:\r
+> Hi Dmitry,\r
+> \r
+> On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > There are some trailing whitespaces in the tests.\r
+> \r
+> those are also produced by the various notmuch-hello functions, and are\r
+> also in the existing tests. If someone is bothered by this, it should be\r
+> fixed in a separate patch.\r
+> \r
+\r
+I only meant trailing whitespaces in test/emacs file in the lines added\r
+by the patch.  Trailing whitespaces in expected results are obviously\r
+fine.\r
+\r
+> > \r
+> > Also, please consider moving the hello sections tests to a separate file\r
+> > (emacs-hello-sections, perhaps?).  I am worried that test/emacs file\r
+> > becomes too big.  And we will probably add more notmuch-hello\r
+> > section-related tests in the future.\r
+> \r
+> I think it's better to split it up into more than just\r
+> emacs-hello-sections and emacs, as there are also quite a few tests\r
+> relating solely to, e.g., -show or -search.\r
+> \r
+\r
+I think splitting emacs tests based on -hello, -show and -search views\r
+is a good idea.  Splitting existing tests is out of scope of this\r
+patch.  But I think it may be a good opportunity to add a new file with\r
+-hello tests.\r
+\r
+> Anyhow, I'll send another rebased version fixing conflicts with the\r
+> search-interface changes.\r
+> \r
+\r
+Thanks, I will try to review it soon.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> Cheers,\r
+> Daniel\r