Re: [PATCH] emacs: Fix mis-named argument to notmuch-get-bodypart-internal

diff --git a/a0/e522cec5de71ab42fe89baba0c7b6796d044a6 b/a0/e522cec5de71ab42fe89baba0c7b6796d044a6
new file mode 100644 (file)
index 0000000..d3e40e3
--- /dev/null
+++ b/a0/e522cec5de71ab42fe89baba0c7b6796d044a6
@@ -0,0 +1,95 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 61AF4431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 19:08:35 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DCj6GzJQ0C4H for <notmuch@notmuchmail.org>;\r
+       Wed, 28 Mar 2012 19:08:34 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU\r
+       [18.7.68.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C55EE431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 19:08:34 -0700 (PDT)\r
+X-AuditID: 12074422-b7fd66d0000008f9-2d-4f73c422d9f5\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 01.B8.02297.224C37F4; Wed, 28 Mar 2012 22:08:34 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2T28XbQ013096; \r
+       Wed, 28 Mar 2012 22:08:34 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2T28VYo002161\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 28 Mar 2012 22:08:32 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SD4mt-0006LK-Cp; Wed, 28 Mar 2012 22:08:31 -0400\r
+Date: Wed, 28 Mar 2012 22:08:31 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+Subject: Re: [PATCH] emacs: Fix mis-named argument to\r
+       notmuch-get-bodypart-internal\r
+Message-ID: <20120329020831.GZ2670@mit.edu>\r
+References: <1332812426-26684-1-git-send-email-amdragon@mit.edu>\r
+       <87ty18kwmd.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87ty18kwmd.fsf@servo.finestructure.net>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42IRYrdT0VU6UuxvsOOnoMWefV4W12/OZHZg\r
+       8rh7msvj2apbzAFMUVw2Kak5mWWpRfp2CVwZR09tYC+Yy14xZ6pSA+MN1i5GTg4JAROJ/y+a\r
+       2SFsMYkL99azdTFycQgJ7GOUuHvwCCOEs4FRYv+eDqjMSSaJC9u/MYK0CAksYZTYMtO1i5GD\r
+       g0VAVeLNbQWQMJuAhsS2/cvBSkQEzCR6vvwBs5kFpCW+/W5mArGFBUIlnkx/wwJi8wpoS5x+\r
+       vxZqZLbEupYFrBBxQYmTM5+wQPRqSdz495IJZBXInOX/OEDCnAKmEtOWdIGNFBVQkZhychvb\r
+       BEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGuqV5uZoleakrpJkZwOLso\r
+       7WD8eVDpEKMAB6MSD+8pzWJ/IdbEsuLK3EOMkhxMSqK88w4DhfiS8lMqMxKLM+KLSnNSiw8x\r
+       SnAwK4nw+u0GyvGmJFZWpRblw6SkOViUxHnVtd75CQmkJ5akZqemFqQWwWRlODiUJHhXgAwV\r
+       LEpNT61Iy8wpQUgzcXCCDOcBGr4PpIa3uCAxtzgzHSJ/ilGXY927K5cZhVjy8vNSpcR5O0CK\r
+       BECKMkrz4ObA0tArRnGgt4R5J4BU8QBTGNykV0BLmICWLDmSD7KkJBEhJdXAmH7njEbALv9K\r
+       1eJvdV6tGTK7F6lNND4SavyjrnljdTW/SZXA4YUBfqeNjvddkux78E7wwWwdTcv7N/Q/RNTP\r
+       OtcnFcCyTuaDTOCiEKYdbmsbdIxqBDW1y8uknGbZKpvMXZj1VuDXyhAn/0LTe93zFud+9thq\r
+       +evXC/PXGVwbJOdLTnvmdqpNiaU4I9FQi7moOBEA9at6DR4DAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 29 Mar 2012 02:08:35 -0000\r
+\r
+Quoth Jameson Graef Rollins on Mar 28 at  6:46 pm:\r
+> On Mon, Mar 26 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > Previously, this function took an argument called "message-id", even\r
+> > though it was a general query, rather than a message ID.  This changes\r
+> > it to "query".\r
+> \r
+> I'm sure the argument was named such because: the function is retrieving\r
+> a message part so the query has to match just a single message, and it's\r
+> only ever given a message id by anything that calls it.  And it's an\r
+> unexposed internal function.  All of this to say that I think it doesn't\r
+> really matter that the argument was named as it was.\r
+\r
+All true.  But there's a difference between a message ID and an id:\r
+query and the argument name threw me off for a moment when I was\r
+writing the id: query quoting patch.  It could be `id-query', I\r
+suppose, but really it could be any query that matches a single\r
+message.\r