Re: [PATCH] go: Update to the current notmuch_database_find_message API

diff --git a/ab/d5a1d89b3ead4652f7d78636913c383be47acc b/ab/d5a1d89b3ead4652f7d78636913c383be47acc
new file mode 100644 (file)
index 0000000..6a4ade5
--- /dev/null
+++ b/ab/d5a1d89b3ead4652f7d78636913c383be47acc
@@ -0,0 +1,102 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7AEF5431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 12:54:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fUYWAnmNCNz4 for <notmuch@notmuchmail.org>;\r
+       Mon, 30 Apr 2012 12:54:29 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 20419431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 12:54:29 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id B811B584BAB\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 21:54:24 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id 13941DF2A5; Mon, 30 Apr 2012 21:54:24 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (unknown [10.1.1.153])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested) (Authenticated sender: teythoon)\r
+       by mail.jade-hamburg.de (Postfix) with ESMTPSA id 7767FDF2A1;\r
+       Mon, 30 Apr 2012 21:54:22 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1SOwfs-0003vx-FK; Mon, 30 Apr 2012 21:54:20 +0200\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+To: David Bremner <david@tethera.net>\r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+In-Reply-To: <87lildph9w.fsf@zancas.localnet>\r
+References: <1335649518-1970-1-git-send-email-amdragon@mit.edu>\r
+       <87lildph9w.fsf@zancas.localnet>\r
+Message-ID: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>\r
+User-Agent: alot/0.3+\r
+Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message\r
+       API\r
+Date: Mon, 30 Apr 2012 21:54:20 +0200\r
+Cc: , notmuch mailing list <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Apr 2012 19:54:30 -0000\r
+\r
+Quoting David Bremner (2012-04-30 13:53:47)\r
+> Austin Clements <amdragon@MIT.EDU> writes:\r
+> =\r
+\r
+> > The signature of notmuch_database_find_message was changed in 02a30767\r
+> > to report errors and the Go bindings were never updated.  This brings\r
+> > the Go bindings in sync with that change and at least makes them\r
+> > compile with Go r60.3, the last release before Go 1.\r
+> =\r
+\r
+> I don't have any easy way to test this, since the current versions in =\r
+\r
+> Debian are all based on Go 1.  On the other hand I guess it doesn't make\r
+> things worse.  Anybody have any objections to this patch?\r
+\r
+lgtm.\r
+\r
+> In the long run we have to decide what to do about these bindings. Seb\r
+> (or anyone else) are you interested in porting them to Go 1 and\r
+> maintaining them?  Otherwise it may be time to deprecate them.\r
+\r
+I care enough for the go environment to keep the go bindings\r
+working. I've updated the bindings, the build infrastructure and the\r
+notmuch-addrlookup utility to go 1. I'll send a patch series as a\r
+followup that is meant to be applied upon Austins patch.\r
+\r
+The last patch in the series is a cleanup of the source code done with\r
+the gofmt utility. Go is somewhat strict in its coding conventions,\r
+but there is a utility that magically formats code. This makes the go\r
+code in the wild remarkably consistent. We should stick to the\r
+conventions too, hence this patch even if it breaks git blame\r
+somewhat.\r
+\r
+I haven't tested the bindings in depth, but the notmuch-addrlookup\r
+utility seems to be working fine.\r
+\r
+Cheers,\r
+Justus\r