[PATCH v3 2/3] emacs: Rename incremental JSON internal variables.
authorMark Walters <markwalters1009@gmail.com>
Wed, 24 Oct 2012 00:13:21 +0000 (01:13 +0100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:49:59 +0000 (09:49 -0800)
06/8a3a53eccd566054c6beebd3963bc9993f1f1b [new file with mode: 0644]

diff --git a/06/8a3a53eccd566054c6beebd3963bc9993f1f1b b/06/8a3a53eccd566054c6beebd3963bc9993f1f1b
new file mode 100644 (file)
index 0000000..628ee59
--- /dev/null
@@ -0,0 +1,152 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A259B431FC0\r
+       for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 17:13:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 7sT1hkUgQ3Ac for <notmuch@notmuchmail.org>;\r
+       Tue, 23 Oct 2012 17:13:49 -0700 (PDT)\r
+Received: from mail-we0-f181.google.com (mail-we0-f181.google.com\r
+       [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 2EF4E431FC9\r
+       for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 17:13:48 -0700 (PDT)\r
+Received: by mail-we0-f181.google.com with SMTP id u54so2726156wey.26\r
+       for <notmuch@notmuchmail.org>; Tue, 23 Oct 2012 17:13:46 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=8wez/w0wRY3dRCLyp0MVlQfsqPVN0HTMnX39ePhaNKc=;\r
+       b=mXceZQ7iIPOsgwytXLTcHNovwmqna/phJjvkVB0ZrZfBUBd26wMb/aM6mnOXE/WKyC\r
+       1IQAMSbDZtEj0GGUpZvmq+n82sWGF6S/qzj/CEaYGsuwnAkCeLZa6iV0zzEFvwexyOcG\r
+       Rq+TYk3ANxV86M+jefiDxJ2X5Pb2hMyLUNko84SQZMKNf3WRK6+mAmIUbtGN+OU+2jFr\r
+       mQQwGCO5EEUXvxJhmfCakbR8+749eUb9997tqY2bvNleXC7Ym0sgX2+xDPaawF2UP+RJ\r
+       oScA6p8rPDdwmW9GPDRl2yqYiOLiEZlbE4umbNUfLn5OTJNnXGGnVDlSgWrd7mMaaQyR\r
+       XoRg==\r
+Received: by 10.216.145.88 with SMTP id o66mr8714244wej.169.1351037626748;\r
+       Tue, 23 Oct 2012 17:13:46 -0700 (PDT)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+       by mx.google.com with ESMTPS id k20sm1387790wiv.11.2012.10.23.17.13.45\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Tue, 23 Oct 2012 17:13:45 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v3 2/3] emacs: Rename incremental JSON internal variables.\r
+Date: Wed, 24 Oct 2012 01:13:21 +0100\r
+Message-Id: <1351037602-11157-3-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+In-Reply-To: <1351037602-11157-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1351037602-11157-1-git-send-email-markwalters1009@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Oct 2012 00:13:51 -0000\r
+\r
+This patch just renames the internal variables for the JSON parser now\r
+it is no longer specific to search mode. It also fixes up the white\r
+space after the previous patch. There should be no functional changes.\r
+---\r
+ emacs/notmuch.el |   46 +++++++++++++++++++++++-----------------------\r
+ 1 files changed, 23 insertions(+), 23 deletions(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index 72a73dc..7e5d052 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -812,11 +812,11 @@ non-authors is found, assume that all of the authors match."\r
+     (insert (apply #'format string objects))\r
+     (insert "\n")))\r
\r
+-(defvar notmuch-search-process-state nil\r
+-  "Parsing state of the search process filter.")\r
++(defvar notmuch-json-state nil\r
++  "State of the internal JSON parser.")\r
\r
+-(defvar notmuch-search-json-parser nil\r
+-  "Incremental JSON parser for the search process filter.")\r
++(defvar notmuch-json-parser nil\r
++  "Internal Incremental JSON parser Object.")\r
\r
+ (defun notmuch-search-process-filter (proc string)\r
+   "Process and filter the output of \"notmuch search\""\r
+@@ -848,40 +848,40 @@ If there is a syntax error, this will attempt to resynchronize\r
+ with the input and will apply ERROR-FUNCTION in buffer\r
+ RESULT-BUFFER to any input that was skipped."\r
+   (let (done)\r
+-    (unless (local-variable-p 'notmuch-search-json-parser)\r
+-      (set (make-local-variable 'notmuch-search-json-parser)\r
++    (unless (local-variable-p 'notmuch-json-parser)\r
++      (set (make-local-variable 'notmuch-json-parser)\r
+          (notmuch-json-create-parser (current-buffer)))\r
+-      (set (make-local-variable 'notmuch-search-process-state) 'begin))\r
+-      (while (not done)\r
+-        (condition-case nil\r
+-            (case notmuch-search-process-state\r
++      (set (make-local-variable 'notmuch-json-state) 'begin))\r
++    (while (not done)\r
++      (condition-case nil\r
++        (case notmuch-json-state\r
+               ((begin)\r
+                ;; Enter the results list\r
+                (if (eq (notmuch-json-begin-compound\r
+-                        notmuch-search-json-parser) 'retry)\r
++                        notmuch-json-parser) 'retry)\r
+                    (setq done t)\r
+-                 (setq notmuch-search-process-state 'result)))\r
++                 (setq notmuch-json-state 'result)))\r
+               ((result)\r
+                ;; Parse a result\r
+-               (let ((result (notmuch-json-read notmuch-search-json-parser)))\r
++               (let ((result (notmuch-json-read notmuch-json-parser)))\r
+                  (case result\r
+-                   ((retry) (setq done t))\r
+-                   ((end) (setq notmuch-search-process-state 'end))\r
++                       ((retry) (setq done t))\r
++                       ((end) (setq notmuch-json-state 'end))\r
+                        (otherwise (with-current-buffer results-buf\r
+                                     (funcall result-function result))))))\r
+               ((end)\r
+                ;; Any trailing data is unexpected\r
+-               (notmuch-json-eof notmuch-search-json-parser)\r
++               (notmuch-json-eof notmuch-json-parser)\r
+                (setq done t)))\r
+-          (json-error\r
+-           ;; Do our best to resynchronize and ensure forward\r
+-           ;; progress\r
+-              (let ((bad (buffer-substring (line-beginning-position)\r
+-                                           (line-end-position))))\r
+-                (forward-line)\r
++      (json-error\r
++       ;; Do our best to resynchronize and ensure forward\r
++       ;; progress\r
++       (let ((bad (buffer-substring (line-beginning-position)\r
++                                    (line-end-position))))\r
++         (forward-line)\r
+          (with-current-buffer results-buf\r
+            (funcall error-function "%s" bad))))))\r
+-      ;; Clear out what we've parsed\r
++    ;; Clear out what we've parsed\r
+     (delete-region (point-min) (point))))\r
\r
+ (defun notmuch-search-tag-all (&optional tag-changes)\r
+-- \r
+1.7.9.1\r
+\r