Re: [PATCH] crypto: return NULL cryptoctx if protocol string is empty.

diff --git a/7d/31e7aa9ac31014fc3d3633476ad7c38cbef8a1 b/7d/31e7aa9ac31014fc3d3633476ad7c38cbef8a1
new file mode 100644 (file)
index 0000000..ce0f44e
--- /dev/null
+++ b/7d/31e7aa9ac31014fc3d3633476ad7c38cbef8a1
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C6BC4431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 20 Jul 2013 05:36:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Xa60ECorVr+O for <notmuch@notmuchmail.org>;\r
+       Sat, 20 Jul 2013 05:36:46 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 14A79431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 20 Jul 2013 05:36:46 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1V0WOy-0002nc-OY; Sat, 20 Jul 2013 09:36:44 -0300\r
+Received: (nullmailer pid 23582 invoked by uid 1000); Sat, 20 Jul 2013\r
+       12:36:41 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>, Notmuch Mail\r
+       <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] crypto: return NULL cryptoctx if protocol string is\r
+ empty.\r
+In-Reply-To: <1374248172-14199-1-git-send-email-jrollins@finestructure.net>\r
+References: <id:51E95500.8000404@fifthhorseman.net>\r
+       <1374248172-14199-1-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.15.2+223~g3484372 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 20 Jul 2013 09:36:41 -0300\r
+Message-ID: <87txjpe7c6.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 20 Jul 2013 12:36:53 -0000\r
+\r
+Jameson Graef Rollins <jrollins@finestructure.net> writes:\r
+\r
+> Badly formed messages that don't specify a protocol in\r
+> signed/encrypted parts, end up with a protocol of NULL.  strcasecmp in\r
+> notmuch_crypto_get_context then segfaults when trying to check it\r
+> against known protocols.  If the protocol is NULL, just return an\r
+> empty context immediately (with appropriate message.)\r
+\r
+Pushed, thanks for the fix\r
+\r
+d\r