--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id BBB18431FAF\r
+ for <notmuch@notmuchmail.org>; Sat, 8 Dec 2012 02:23:30 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id g8IqSLKq5Q1g for <notmuch@notmuchmail.org>;\r
+ Sat, 8 Dec 2012 02:23:29 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id D3D8A431FAE\r
+ for <notmuch@notmuchmail.org>; Sat, 8 Dec 2012 02:23:28 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1ThHZ8-0001Cm-Je; Sat, 08 Dec 2012 10:23:27 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1ThHZ8-0005nd-8F; Sat, 08 Dec 2012 10:23:26 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v3b 3/9] util: add string-util.[ch]\r
+In-Reply-To: <1354843607-17980-4-git-send-email-david@tethera.net>\r
+References: <1354843607-17980-1-git-send-email-david@tethera.net>\r
+ <1354843607-17980-4-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 08 Dec 2012 10:23:31 +0000\r
+Message-ID: <87624chmfw.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 474b2fde85e2a27169ebced9ccff334b (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 08 Dec 2012 10:23:30 -0000\r
+\r
+\r
+On Fri, 07 Dec 2012, david@tethera.net wrote:\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> This is to give a home to strtok_len. It's a bit silly to add a header\r
+> for one routine, but it needs to be shared between several compilation\r
+> units (or at least that's the most natural design).\r
+> ---\r
+> util/Makefile.local | 3 ++-\r
+> util/string-util.c | 34 ++++++++++++++++++++++++++++++++++\r
+> util/string-util.h | 19 +++++++++++++++++++\r
+> 3 files changed, 55 insertions(+), 1 deletion(-)\r
+> create mode 100644 util/string-util.c\r
+> create mode 100644 util/string-util.h\r
+>\r
+> diff --git a/util/Makefile.local b/util/Makefile.local\r
+> index 3ca623e..a11e35b 100644\r
+> --- a/util/Makefile.local\r
+> +++ b/util/Makefile.local\r
+> @@ -3,7 +3,8 @@\r
+> dir := util\r
+> extra_cflags += -I$(srcdir)/$(dir)\r
+> \r
+> -libutil_c_srcs := $(dir)/xutil.c $(dir)/error_util.c $(dir)/hex-escape.c\r
+> +libutil_c_srcs := $(dir)/xutil.c $(dir)/error_util.c $(dir)/hex-escape.c \\r
+> + $(dir)/string-util.c\r
+> \r
+> libutil_modules := $(libutil_c_srcs:.c=.o)\r
+> \r
+> diff --git a/util/string-util.c b/util/string-util.c\r
+> new file mode 100644\r
+> index 0000000..44f8cd3\r
+> --- /dev/null\r
+> +++ b/util/string-util.c\r
+> @@ -0,0 +1,34 @@\r
+> +/* string-util.c - Extra or enhanced routines for null terminated strings.\r
+> + *\r
+> + * Copyright (c) 2012 Jani Nikula\r
+> + *\r
+> + * This program is free software: you can redistribute it and/or modify\r
+> + * it under the terms of the GNU General Public License as published by\r
+> + * the Free Software Foundation, either version 3 of the License, or\r
+> + * (at your option) any later version.\r
+> + *\r
+> + * This program is distributed in the hope that it will be useful,\r
+> + * but WITHOUT ANY WARRANTY; without even the implied warranty of\r
+> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\r
+> + * GNU General Public License for more details.\r
+> + *\r
+> + * You should have received a copy of the GNU General Public License\r
+> + * along with this program. If not, see http://www.gnu.org/licenses/ .\r
+> + *\r
+> + * Author: Jani Nikula <jani@nikula.org>\r
+> + */\r
+> +\r
+> +\r
+> +#include "string-util.h"\r
+> +\r
+> +char *\r
+> +strtok_len (char *s, const char *delim, size_t *len)\r
+> +{\r
+> + /* skip initial delims */\r
+> + s += strspn (s, delim);\r
+> +\r
+> + /* length of token */\r
+> + *len = strcspn (s, delim);\r
+> +\r
+> + return *len ? s : NULL;\r
+> +}\r
+> diff --git a/util/string-util.h b/util/string-util.h\r
+> new file mode 100644\r
+> index 0000000..696da40\r
+> --- /dev/null\r
+> +++ b/util/string-util.h\r
+> @@ -0,0 +1,19 @@\r
+> +#ifndef _STRING_UTIL_H\r
+> +#define _STRING_UTIL_H\r
+> +\r
+> +#include <string.h>\r
+> +\r
+> +/* like strtok(3), but without state, and doesn't modify s. usage pattern:\r
+> + *\r
+> + * const char *tok = input;\r
+> + * const char *delim = " \t";\r
+> + * size_t tok_len = 0;\r
+> + *\r
+> + * while ((tok = strtok_len (tok + tok_len, delim, &tok_len)) != NULL) {\r
+> + * // do stuff with string tok of length tok_len\r
+> + * }\r
+\r
+Hi\r
+\r
+Some possibly silly comments on the comment. strtok(3) seems to return a\r
+null terminated string and this does not. Might be worth including in\r
+the comment? Secondly every time I read this I read "..modify s. usage\r
+pattern" as one ongoing sentence with s. an abbreviation. Perhaps a\r
+capital u? and maybe str or string rather than s?\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> + */\r
+> +\r
+> +char *strtok_len (char *s, const char *delim, size_t *len);\r
+> +\r
+> +#endif\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff