Re: [PATCH v8 0/3] notmuch-search: Structured Output Formatters

diff --git a/9f/270f7706aa74e54c9f3e44a398c82aa9535a46 b/9f/270f7706aa74e54c9f3e44a398c82aa9535a46
new file mode 100644 (file)
index 0000000..5ce5702
--- /dev/null
+++ b/9f/270f7706aa74e54c9f3e44a398c82aa9535a46
@@ -0,0 +1,127 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 41A5C431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Jul 2012 06:48:35 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id j1apbmqJ79fI for <notmuch@notmuchmail.org>;\r
+       Mon, 23 Jul 2012 06:48:34 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU\r
+       [18.7.68.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7F5DD431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 23 Jul 2012 06:48:34 -0700 (PDT)\r
+X-AuditID: 12074422-b7f1f6d00000090b-b0-500d56312734\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 43.B3.02315.1365D005; Mon, 23 Jul 2012 09:48:33 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q6NDmXJN004159; \r
+       Mon, 23 Jul 2012 09:48:33 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6NDmVdF010846\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Mon, 23 Jul 2012 09:48:32 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1StIzu-0002CZ-U7; Mon, 23 Jul 2012 09:48:30 -0400\r
+Date: Mon, 23 Jul 2012 09:48:30 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: craven@gmx.net\r
+Subject: Re: [PATCH v8 0/3] notmuch-search: Structured Output Formatters\r
+Message-ID: <20120723134808.GF31834@mit.edu>\r
+References: <1343039986-2732-1-git-send-email-craven@gmx.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1343039986-2732-1-git-send-email-craven@gmx.net>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1jUM4w0weHDZ0mJvQzujxfWbM5kd\r
+       mDwWb9rP5vFs1S3mAKYoLpuU1JzMstQifbsErozLh5YwF1zhr/g47wZbA+MBni5GTg4JAROJ\r
+       +8dXsUHYYhIX7q0Hsrk4hAT2MUo8v/mMGcLZwCjxau4PFgjnJJPEvt/7WCGcJYwSy5e+ZALp\r
+       ZxFQlehf8grMZhPQkNi2fzkjiC0iICQx6csrFhCbWUBa4tvvZrAaYQEPiSfNz8HivAI6Egsm\r
+       zmQFsYUEbCX6vp5ghIgLSpyc+QSqV0vixj+QXRxgc5b/4wAJcwrYSTSt3MsMYosKqEhMObmN\r
+       bQKj0Cwk3bOQdM9C6F7AyLyKUTYlt0o3NzEzpzg1Wbc4OTEvL7VI11QvN7NELzWldBMjKLDZ\r
+       XZR2MP48qHSIUYCDUYmH17KKJ0CINbGsuDL3EKMkB5OSKG99KG+AEF9SfkplRmJxRnxRaU5q\r
+       8SFGCQ5mJRHey9e5A4R4UxIrq1KL8mFS0hwsSuK811Ju+gsJpCeWpGanphakFsFkZTg4lCR4\r
+       O0CGChalpqdWpGXmlCCkmTg4QYbzAA1fDVLDW1yQmFucmQ6RP8WoKCXOWwqSEABJZJTmwfXC\r
+       Es8rRnGgV4R5y0GqeIBJC677FdBgJqDB0llcIINLEhFSUg2MBf8vmRo7B/U+Xf7sot0xtvfK\r
+       n389W74x7mqRvmOEkm6u51HNv0LrD280te2U9rS7s+44268Fx7Jrg74zcSz7L6qSfXGzVfH3\r
+       a99FWyIiNt1ijY877e7v6SJ3dUJZutOKXYcOLWoO+9oUJ6/56Zn4hMex2t9td1W4inr4imZP\r
+       +3A8uj7yqv9cJZbijERDLeai4kQAzTga7xcDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 23 Jul 2012 13:48:35 -0000\r
+\r
+LGTM\r
+\r
+Quoth craven@gmx.net on Jul 23 at 12:39 pm:\r
+> From: <craven@gmx.net>\r
+> \r
+> Currently there is no easy way to add support for different structured\r
+> formatters (like JSON). For example, adding support for S-Expressions\r
+> would result in code duplication.\r
+> \r
+> This patch series amends the situation by introducing structured\r
+> formatters, which allow different implementations of structures like\r
+> lists, maps, strings and numbers.\r
+> \r
+> The new code in sprinter.h and sprinter-json.c can be used instead of\r
+> the current ad-hoc output in all parts of notmuch, a patch for\r
+> notmuch-search.c is included.\r
+> \r
+> In a later patch, all other parts of notmuch should be adapted to the\r
+> structured formatters, and the creation of formatters should be\r
+> centralised (to make adding new formatters easier).\r
+> \r
+> A "structured" formatter is provided for notmuch-search that prints the\r
+> current text format. This removes almost all the special-casing from\r
+> notmuch-search.c.\r
+> \r
+> Changes versus v7 of this patch:\r
+> - added {} around "else" blocks (as mentioned in\r
+>   id:20120722160843.GC31834@mit.edu)\r
+> - added fallback to INTERNAL_ERROR (which should never be called) in\r
+>   notmuch-search.c if format is unknown (as mentioned in\r
+>   id:m2r4s694ly.fsf@guru.guru-group.fi).\r
+> \r
+> Summary: \r
+> \r
+> Peter Feigl (3):\r
+>   Add support for structured output formatters.\r
+>   Add structured output formatter for JSON and plain text (but don't\r
+>     use them yet).\r
+>   Use the structured formatters in notmuch-search.c.\r
+> \r
+>  Makefile.local   |   2 +\r
+>  notmuch-search.c | 304 ++++++++++++++---------------------------------\r
+>  sprinter-json.c  | 187 +++++++++++++++++++++++++++++\r
+>  sprinter-text.c  | 126 ++++++++++++++++++++\r
+>  sprinter.h       |  68 +++++++++++\r
+>  test/json        |  34 +++---\r
+>  6 files changed, 489 insertions(+), 232 deletions(-)\r
+>  create mode 100644 sprinter-json.c\r
+>  create mode 100644 sprinter-text.c\r
+>  create mode 100644 sprinter.h\r
+> \r