Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t

diff --git a/0f/d706ca94b909b1656d13c501820f17ad71ad86 b/0f/d706ca94b909b1656d13c501820f17ad71ad86
new file mode 100644 (file)
index 0000000..f4a88af
--- /dev/null
+++ b/0f/d706ca94b909b1656d13c501820f17ad71ad86
@@ -0,0 +1,95 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 16DD6431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 08:49:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Hp2jRqMtQuQP for <notmuch@notmuchmail.org>;\r
+       Sat, 20 Oct 2012 08:49:09 -0700 (PDT)\r
+Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com\r
+       [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8160C431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 08:49:09 -0700 (PDT)\r
+Received: by mail-vb0-f53.google.com with SMTP id fc21so1630032vbb.26\r
+       for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 08:49:07 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=HVdoChQffd+po/3Q/yJr4BjVUzLpd3dHtL4jKVB88GU=;\r
+       b=vz5pMIiXD0SHDWcfYK8cbgGbNIuF7xJ0FygQTkmR+6aUdhxEIPQKCILJ86twmY0UzA\r
+       fuK3D8G7ZeeEQEvrteBkaNFzF/sKj3V3Ie74AF5ivFOkGI1Wn8bNfdN22DjP19pl7tG1\r
+       hXxEg/M0t+XI2p8Cv0QOVdwGESbAhTYeFpyn3ADXR3zUlY7FfxowquC+xIIuydmwXNph\r
+       BA6wja7PL37hcsIkTKgIjY59BApllH0KmQnWc3kAz6HSR3/sLZeFYVN0ktqZb/z9gQqf\r
+       YjtbH3iHUWQgueq2NC4MSx05/+QK3jXv7T5ecuhjxdDhhOnVgvxN4MlNYt2ozwd1TlsY\r
+       9keQ==\r
+Received: by 10.220.221.203 with SMTP id id11mr6211516vcb.42.1350748147266;\r
+       Sat, 20 Oct 2012 08:49:07 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id g5sm4347339vez.6.2012.10.20.08.49.05\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sat, 20 Oct 2012 08:49:06 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, Adrien Bustany <adrien@bustany.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/2] Add flush/reopen methods to notmuch_database_t\r
+In-Reply-To: <87vce7yllt.fsf@nikula.org>\r
+References: <1342723401-26103-1-git-send-email-adrien@bustany.org>\r
+       <1350510742-13447-1-git-send-email-adrien@bustany.org>\r
+       <87vce7yllt.fsf@nikula.org>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 20 Oct 2012 11:49:04 -0400\r
+Message-ID: <87y5j15ekv.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 20 Oct 2012 15:49:10 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> On Wed, 17 Oct 2012, Adrien Bustany <adrien@bustany.org> wrote:\r
+>> The code of the patches in unchanged, but the formatting issues are now\r
+>> hopefully fixed.\r
+>\r
+> Hi Adrien, please check at what version flush and reopen have been\r
+> introduced to xapian. If they are new-ish (I don't know, didn't have the\r
+> time to check), please add appropriate #ifdefs. [1] lays the groundwork\r
+> for this. We'll also need to decide what is the minimum xapian version\r
+> required in general, i.e. features earlier than that don't need\r
+> conditional compilation.\r
+\r
+Hi! The new versions of these patches are still pretty trivial and they\r
+still look OK to me, but based on Jani's prompting I decided to look up\r
+the methods. Seems that flush() is a very old (pre-1.1.0, 2009-04) name\r
+for commit(), which is the preferred name these days. You should\r
+probably therefore rename the function notmuch_database_commit, and have\r
+it call the WritableDatabase::commit() method.\r
+\r
+reopen() is a very very old method, seems like it has been around since\r
+2004.\r
+\r
+So I think Adrien is safe from having to do version checks, but we\r
+should probably use commit() instead of flush().\r
+\r
+Ethan\r