Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value

diff --git a/d5/5e6de0a9f6f27359f2f3f7e4e71e5eac84e2ca b/d5/5e6de0a9f6f27359f2f3f7e4e71e5eac84e2ca
new file mode 100644 (file)
index 0000000..7aef070
--- /dev/null
+++ b/d5/5e6de0a9f6f27359f2f3f7e4e71e5eac84e2ca
@@ -0,0 +1,68 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6EF76431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Jan 2013 06:37:52 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 3cGhGhGt8a2X for <notmuch@notmuchmail.org>;\r
+       Sun, 13 Jan 2013 06:37:50 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 57CDE431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Jan 2013 06:37:50 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TuOgy-00066M-QO; Sun, 13 Jan 2013 10:37:49 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TuOgt-0007G8-5r; Sun, 13 Jan 2013 10:37:39 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value\r
+In-Reply-To: <1357976414-7468-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1357976414-7468-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.14+257~ge43e0af (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 13 Jan 2013 10:37:39 -0400\r
+Message-ID: <87fw25cfnw.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Jan 2013 14:37:52 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> In case last input for batch tagging was either invalid or skippable\r
+> line, notmuch command exited with non-zero value.\r
+> After this change if there is at least one invalid line, notmuch\r
+> command will exit with non-zero value. Additionally, skipped lines\r
+> (last or other) doesn't cause non-zero value to be returned.\r
+\r
+This looks OK. In a perfect world we'd have a test for return values.\r
+\r
+d\r