--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 8267B431FB6\r
+ for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 01:43:18 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id vwFmXCO6dTEn for <notmuch@notmuchmail.org>;\r
+ Sat, 28 Jan 2012 01:43:17 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 904ED431FAE\r
+ for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 01:43:17 -0800 (PST)\r
+Received: by bkbzt19 with SMTP id zt19so2381110bkb.26\r
+ for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 01:43:16 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type;\r
+ bh=2SqD3BYL5NfNsmtZlZQ8IP2Xj0+bejWHVQjYxiyA14U=;\r
+ b=tuRsgcfiB09xWUnUVfJj+pUfouJ5bd92clW5uSa2QSPOp4EJEfo/arrevW3otECi7u\r
+ 3M4TO0sxnTlN19axUtvv+OiVRV9tznN44mCn+I+WNz4leLC/yw2bmadCUnGc7uCyN9zr\r
+ rbGdHh5xvl7QQQp+DQ/6gaCmrdAlgWYn2PlP4=\r
+Received: by 10.205.124.15 with SMTP id gm15mr4892112bkc.63.1327743796148;\r
+ Sat, 28 Jan 2012 01:43:16 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id ek9sm22158588bkb.10.2012.01.28.01.43.14\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Sat, 28 Jan 2012 01:43:15 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH 8/6] emacs: use message ids instead of thread id in\r
+ `notmuch-show-operate-all'\r
+In-Reply-To:\r
+ <CAB+hUn8feOnr8N_mGXw+wKA6exZG3V-7uW0Yz6+wPN=B+tCNMQ@mail.gmail.com>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <1327730348-6466-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <CAB+hUn8feOnr8N_mGXw+wKA6exZG3V-7uW0Yz6+wPN=B+tCNMQ@mail.gmail.com>\r
+User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 28 Jan 2012 13:42:06 +0400\r
+Message-ID: <87wr8c88pd.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 28 Jan 2012 09:43:18 -0000\r
+\r
+Hi Jani.\r
+\r
+On Sat, 28 Jan 2012 11:09:45 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> I guess this now includes the optimization of doing the tagging in a single\r
+> call to notmuch tag. (As opposed to calling it once per msg like it used to\r
+> be a while back.)\r
+\r
+This patch changes the code which was added few patches earlier in the\r
+series. And rational for it is not an optimization but a bug fix as\r
+described in the preamble.\r
+\r
+> There was some discussion about the cmdline length for\r
+> large threads potentially growing too big when I sent such an optimization\r
+> patch, shall we just ignore that and hope for the best?\r
+\r
+Sorry, I think I did not read that discussion in details. I have never\r
+hit this issue. So, for now, I do not care about it.\r
+\r
+Notmuch-search range tagging works in a similar way, constructing search\r
+string of OR'ed thread ids. So the patch is consistent with the\r
+existing code.\r
+\r
+> I guess an idea was\r
+> to limit to, say, a few hundred msg ids per command. (Again, sorry I can't\r
+> look up the earlier thread now.)\r
+> \r
+\r
+That may be a solution. Though, I think it should rely on system's\r
+command line limit instead of magic constants.\r
+\r
+Anyway, this problem is out of scope of this patch series. Currently,\r
+neither notmuch-search region tagging code nor the proposed patch try to\r
+solve the issue. If and when a proper solution is found, we should\r
+implement it for both (or probably more) cases (provided this patch gets\r
+accepted).\r
+\r
+Regards,\r
+ Dmitry\r
+\r
+> On Jan 28, 2012 8:00 AM, "Dmitry Kurochkin" <dmitry.kurochkin@gmail.com>\r
+> wrote:\r
+> >\r
+> > Before the change, `notmuch-show-operate-all' used thread id for\r
+> > "notmuch tag" search. This could result in tagging unexpected\r
+> > messages that were added to the thread after the notmuch-show buffer\r
+> > was created. The patch changes `notmuch-show-operate-all' to use ids\r
+> > of shown messages to fix this.\r
+> > ---\r
+> > emacs/notmuch-show.el | 23 ++++++++++++++++++++++-\r
+> > 1 files changed, 22 insertions(+), 1 deletions(-)\r
+> >\r
+> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> > index 2ca4d92..e606224 100644\r
+> > --- a/emacs/notmuch-show.el\r
+> > +++ b/emacs/notmuch-show.el\r
+> > @@ -1170,6 +1170,15 @@ All currently available key bindings:\r
+> > (notmuch-show-move-to-message-top)\r
+> > t))\r
+> >\r
+> > +(defun notmuch-show-mapc (function)\r
+> > + "Iterate through all messages with\r
+> > +`notmuch-show-goto-message-next' and call `function' for side\r
+> > +effects."\r
+> > + (save-excursion\r
+> > + (goto-char (point-min))\r
+> > + (loop do (funcall function)\r
+> > + while (notmuch-show-goto-message-next))))\r
+> > +\r
+> > ;; Functions relating to the visibility of messages and their\r
+> > ;; components.\r
+> >\r
+> > @@ -1222,6 +1231,18 @@ Some useful entries are:\r
+> > "Return the message id of the current message."\r
+> > (concat "id:\"" (notmuch-show-get-prop :id) "\""))\r
+> >\r
+> > +(defun notmuch-show-get-messages-ids ()\r
+> > + "Return all message ids of currently shown messages."\r
+> > + (let ((message-ids))\r
+> > + (notmuch-show-mapc\r
+> > + (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
+> > + message-ids))\r
+> > +\r
+> > +(defun notmuch-show-get-messages-ids-search ()\r
+> > + "Return a search string for all message ids of currently shown\r
+> > +messages."\r
+> > + (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))\r
+> > +\r
+> > ;; dme: Would it make sense to use a macro for many of these?\r
+> >\r
+> > (defun notmuch-show-get-filename ()\r
+> > @@ -1496,7 +1517,7 @@ i.e. a list of tags to change with '+' and '-'\r
+> prefixes."\r
+> > `Changed-tags' is a list of tag operations for \"notmuch tag\",\r
+> > i.e. a list of tags to change with '+' and '-' prefixes."\r
+> > (interactive (notmuch-select-tags-with-completion nil\r
+> notmuch-show-thread-id))\r
+> > - (apply 'notmuch-tag notmuch-show-thread-id changed-tags)\r
+> > + (apply 'notmuch-tag (notmuch-show-get-messages-ids-search)\r
+> changed-tags)\r
+> > (save-excursion\r
+> > (goto-char (point-min))\r
+> > (loop do (let* ((current-tags (notmuch-show-get-tags))\r
+> > --\r
+> > 1.7.8.3\r
+> >\r
+> > _______________________________________________\r
+> > notmuch mailing list\r
+> > notmuch@notmuchmail.org\r
+> > http://notmuchmail.org/mailman/listinfo/notmuch\r
+Non-text part: text/html\r
projects / notmuch-archives.git / commitdiff