Re: [PATCH] contrib: pick: bugfix for pick splitting the window excessively

diff --git a/6c/faa231d713d461d681c26b9e2d943a8accfc45 b/6c/faa231d713d461d681c26b9e2d943a8accfc45
new file mode 100644 (file)
index 0000000..33e308e
--- /dev/null
+++ b/6c/faa231d713d461d681c26b9e2d943a8accfc45
@@ -0,0 +1,125 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C590F431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 10 Dec 2012 15:13:09 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id LPzL4B6Z2v3h for <notmuch@notmuchmail.org>;\r
+       Mon, 10 Dec 2012 15:13:09 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 52D74431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 10 Dec 2012 15:13:09 -0800 (PST)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 5FEF1328009;\r
+       Mon, 10 Dec 2012 15:13:08 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (gwave-89.ligo.caltech.edu [131.215.114.89])\r
+       (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id E82BE328182;\r
+       Mon, 10 Dec 2012 15:13:00 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id C3DB661725; Mon, 10 Dec 2012 10:26:44 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: bugfix for pick splitting the window\r
+       excessively\r
+In-Reply-To: <1355084249-17523-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1355084249-17523-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+157~g146ede5 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 10 Dec 2012 10:26:42 -0800\r
+Message-ID: <87fw3dbw65.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 10 Dec 2012 23:13:09 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sun, Dec 09 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Previously if you carried on past the last message in a pick view pick\r
+> would get confused and `forget' about the split pane and would try and\r
+> re-split when moving up again. This was due to faulty logic in\r
+> notmuch-pick-show-message: something that should have been in the (when m=\r
+essage)\r
+> clause was not.\r
+>\r
+> Thanks to jrollins for the bug report.\r
+> ---\r
+>\r
+> A simple bugfix: I can reproduce the bug that jrollins found and this\r
+> fixes it for both of us.\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |    4 ++--\r
+>  1 files changed, 2 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/=\r
+notmuch-pick.el\r
+> index 63776d5..a46ef6e 100644\r
+> --- a/contrib/notmuch-pick/notmuch-pick.el\r
+> +++ b/contrib/notmuch-pick/notmuch-pick.el\r
+> @@ -402,8 +402,8 @@ Does NOT change the database."\r
+>        (with-selected-window notmuch-pick-message-window\r
+>      (setq current-prefix-arg '(4))\r
+>      (setq buffer (notmuch-show id nil nil nil)))\r
+> -      (notmuch-pick-tag-update-display (list "-unread")))\r
+> -    (setq notmuch-pick-message-buffer buffer)))\r
+> +      (notmuch-pick-tag-update-display (list "-unread"))\r
+> +      (setq notmuch-pick-message-buffer buffer))))\r
+>=20=20\r
+>  (defun notmuch-pick-show-message-out ()\r
+>    "Show the current message (in whole window)."\r
+\r
+Sorry, I should have responded to this immediately.  This is a bug fix,\r
+and I've tested it and it works perfectly.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJQxiliAAoJEO00zqvie6q8VPkP/1l82GOEFf+d2SGEVRiw+3h4\r
+md3z+SJfcagY1XpGdxo2/Q0UqkrjZ8m4rJdmkCYOseBosGqaF6nXNCKoikE/4a2b\r
+pY1ryqZIK4dtsiUF5UuQxRJ6ppWPKDrycyoEQtxR0nzD6grSfYvsLeUXDoNn8CDL\r
+SziONi1L18hCvLoNeMQ/uZEbX2C0dRbvn+tOwtDrjJeGPu8TsN3rqDkg0/ihekil\r
+oRaFd4nxVrqRhOTi9RS8VsCQFZsl+vfG2og5d8RFvUWTvSDdlAVKCKBGt0LRseS5\r
+4ZL2bTcvxzaeBe3b5vV2224RPxNsTPh6yzJHJGmbe2LEmYUuzlteniuikW4pBz0G\r
+fW+DNesTSUCHmjWsq4hTEe4LTiJes1QQ+nm0Yt59hR8l0FIOyixZH8Gj8BuoL7Zw\r
+8dGV27nBdE2gPt+TSAzEMMQEBXMnGHmu/CAnO8bK4uXNDGpDKoTaaVOWhh4h1NBN\r
+07zelTM6GOtmpPFBGh/zjV2lbqujTeq3kTetiNmpFryfvRYCXk3TeOEBz6bUUl29\r
+LHvCHdqkBj3hP3dTk1KbZvEW9A4bwjEkiJBHs4oCDPE5xXlHk3Lf8qsM38tEmiKH\r
+gC7iT3VCjt7AICfeAm80qcAUUwAX0dSLqgGRMHHPgLBHGJGht5iIWWp4kn2Xwl8c\r
+MxdNGDNTQWe2f/POkEVK\r
+=sAE7\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r