Parsing regression with gmime-2.6?

diff --git a/d3/0394f4cb605500acde053f977eb8c59bbdd84e b/d3/0394f4cb605500acde053f977eb8c59bbdd84e
new file mode 100644 (file)
index 0000000..8230a0a
--- /dev/null
+++ b/d3/0394f4cb605500acde053f977eb8c59bbdd84e
@@ -0,0 +1,97 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0990B431FBC\r
+       for <notmuch@notmuchmail.org>; Tue,  6 Mar 2012 14:04:59 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id EKZnNC1WucaA for <notmuch@notmuchmail.org>;\r
+       Tue,  6 Mar 2012 14:04:58 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 69209431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  6 Mar 2012 14:04:58 -0800 (PST)\r
+Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.166.230.117] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1S52V6-0004R0-Jc; Tue, 06 Mar 2012 18:04:56 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1S52V0-0007wB-Sn; Tue, 06 Mar 2012 18:04:50 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Parsing regression with gmime-2.6?\r
+In-Reply-To: <1331058417-13776-1-git-send-email-amdragon@mit.edu>\r
+References: <87d38w2e7h.fsf@zancas.localnet>\r
+       <1331058417-13776-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.11.1+265~g4110e32 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 06 Mar 2012 18:04:50 -0400\r
+Message-ID: <87wr6xmlml.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 06 Mar 2012 22:04:59 -0000\r
+\r
+On Tue,  6 Mar 2012 18:26:57 +0000, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> ---\r
+>  mime-node.c |   15 +++++++++++++++\r
+>  1 files changed, 15 insertions(+), 0 deletions(-)\r
+\r
+There seems to be something weird going on with gmime-2.6; maybe we\r
+didn't catch some api change? \r
+\r
+I noticed a surprising number of messages failing to parse, so I wrote a\r
+script to take a random sample of 1000 messages and run notmuch show on\r
+them. A shocking 650 to 700 of them fail to parse with gmime-2.6. No\r
+failures are reported with gmime-2.4.\r
+\r
+I tried with your patch, and then took a couple of the id's it reported\r
+and tried them on the release branch, and the failed (segfaulted) there.\r
+\r
+I don't know at this point if it is something specific to my setup, or\r
+my testing methedology is just hare-brained, but I'd appreciate it if\r
+people could try austin's patch, gmime-2.6, and my script on their\r
+mailstore and let me know how many id's it spits out (if any).\r
+\r
+#!/usr/bin/bash\r
+\r
+NOTMUCH=${NOTMUCH-notmuch}\r
+\r
+if [ ! -f test-ids.txt ]; then\r
+    notmuch dump | shuf -n 1000 | cut -f1 -d' ' > test-ids.txt\r
+else\r
+    echo "Re-using test-ids.txt" 1>&2\r
+fi\r
+\r
+while read id; do\r
+    output=$(${NOTMUCH} show --format=json id:$id 2>&1 1>/dev/null)\r
+    case "$output" in\r
+       "Failed to parse"*)\r
+           echo $id\r
+           ;;\r
+       *)\r
+    esac\r
+done <test-ids.txt\r