--- /dev/null
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1AF08429E21\r
+ for <notmuch@notmuchmail.org>; Sun, 8 Jan 2012 18:50:06 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Cwf2JEqR0gtG for <notmuch@notmuchmail.org>;\r
+ Sun, 8 Jan 2012 18:50:05 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+ [131.215.239.19])\r
+ by olra.theworths.org (Postfix) with ESMTP id 9E229431FB6\r
+ for <notmuch@notmuchmail.org>; Sun, 8 Jan 2012 18:50:05 -0800 (PST)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+ by earth-doxen-postvirus (Postfix) with ESMTP id 2A3E466E0023;\r
+ Sun, 8 Jan 2012 18:50:04 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com\r
+ [76.174.137.84]) (Authenticated sender: jrollins)\r
+ by earth-doxen-submit (Postfix) with ESMTP id 0884C66E00E0;\r
+ Sun, 8 Jan 2012 18:49:59 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+ id 84794A4A; Sun, 8 Jan 2012 18:49:59 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Aaron Ecay <aaronecay@gmail.com>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal\r
+ function for general thread tagging\r
+In-Reply-To: <m239bpk7h0.fsf@gmail.com>\r
+References: <1325975294-646-1-git-send-email-jrollins@finestructure.net>\r
+ <1325975294-646-2-git-send-email-jrollins@finestructure.net>\r
+ <1325975294-646-3-git-send-email-jrollins@finestructure.net>\r
+ <m239bpk7h0.fsf@gmail.com>\r
+User-Agent: Notmuch/0.10.2+168~g34b8bac (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 08 Jan 2012 18:49:56 -0800\r
+Message-ID: <87boqdr3mz.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Jan 2012 02:50:06 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+Thanks so much for the review, Aaron.\r
+\r
+On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:\r
+> A couple of comments on the arguments:\r
+> - It would be good to make show-next &optional. This will enable code\r
+> to call the fn with only two arguments, and not showing next will be\r
+> the default behavior.\r
+\r
+That's a nice idea. Probably better for a separate patch, though.\r
+\r
+> - A more lispy way of specifying the sign would be to use a\r
+> boolean. Perhaps you could call this =E2=80=9Cremove=E2=80=9D; a value=\r
+ of =E2=80=98t=E2=80=99 would\r
+> remove the tag; =E2=80=98nil=E2=80=99 would add it. Moving this argume=\r
+nt after =E2=80=98tag=E2=80=99\r
+> and also making it &optional woudl allow this fn to be called with one\r
+> arg to add a tag. (Maybe this is too minimalist and API, however.)=20\r
+\r
+That might be more lispy, but it seems a lot less clear to me. It might\r
+save a few keystrokes when coding, but it would definitely make the code\r
+a lot harder to read ("remove" to add a tag?). I think I would prefer\r
+people to give the sign explicitly.\r
+\r
+> No second set of parens is needed around tag-function.\r
+\r
+Yeah, I've seen this either way. I guess it's just a stylistic choice.\r
+\r
+I think it might make sense, but again I think that's out of the scope\r
+of this patch series. The point was to make a minimal set of\r
+modifications here. If we want to separate out the functionality, we\r
+should do that in a separate patch.\r
+\r
+Thanks again for the review.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPClXVAAoJEO00zqvie6q88GcP/jPFYZv1beZqV9ohNEpF8vfo\r
+Jz+9rrKhW+85Sb2p6yjRq7F9zt4L6HBCLyhL6iIUOMgyD3RI/cSSGlOVqzc/sxPk\r
+8r5lYYIVa4J+61zXCh9anTh8VqKzCmVoVSGTlzCjzj4dfKAIyfI+HR7z86H3Egf3\r
+xDD5iMyt2SfiWOYmL3gCu2uYNKGvZ21okiRLbbbpfg5jZS9S/mZKlR9FvILxN1Le\r
+ftpEakv7qUkqfPL5yZOyZeoQ2/PyRf6hGeWswnqF/jJsliKhh0YmwkYkDcXk31XV\r
+2pSCAZcHJZCiFdZlA0OX1OJUWYLDlyeiKOOxZQcJMT1iUOTRN+YhGhRAy3NlmKvn\r
+9Oe3iuLhP0f7WG7/bXeuCAuO3LbQkaCZZnaDBHw3lz0coJPyM+2SYLnd2XJj9Q6T\r
+KRTP0ZwTNN/L0DBDmfS0i45oxFj4JXna5GVHfKnwTTf5EeXegs38VwAFgVY6I3ba\r
+Qki5KgTn1mNkmQBUIWYOwbb0HeIvaUhMInJKzoPWF3w42ZBUwa5Ak3LZ66lca3OW\r
+YuHZN3XRiiwOPNr4RHMT/ryrPvkZMq0/k1ejJVQ7A+EP5dVEfwBGGuwUBkHOX/Pj\r
+Bt1bPyNClwNblND3XbxXffP8W5iYpO4K8gQUvJjvMvUcsQr/yVJ1RFCyJjhxrbHr\r
+Jd+TLFsE/6X4XMX3kQ/H\r
+=46f2\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff