Re: [PATCH] test: make test_expect_equal_file() arguments flexible

diff --git a/2b/fcedbe31dca4e6c63c5613e9a77072d8ca9561 b/2b/fcedbe31dca4e6c63c5613e9a77072d8ca9561
new file mode 100644 (file)
index 0000000..36f9374
--- /dev/null
+++ b/2b/fcedbe31dca4e6c63c5613e9a77072d8ca9561
@@ -0,0 +1,79 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5BBFD431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 07:25:17 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id jPHip1a7hKFs for <notmuch@notmuchmail.org>;\r
+       Thu,  2 Feb 2012 07:25:16 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id C37E9431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 07:25:16 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 9D5D768055; Thu,  2 Feb 2012 17:25:19 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Edmondson <dme@dme.org>,\r
+       Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible\r
+In-Reply-To: <cuny5sl5mp7.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87r4yfszx9.fsf@servo.finestructure.net>\r
+       <87pqdync64.fsf@gmail.com> <m262fqc0wv.fsf@guru.guru-group.fi>\r
+       <87k446n8ji.fsf@gmail.com> <87ehuetqjz.fsf@servo.finestructure.net>\r
+       <cuny5sl5mp7.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.11+146~geb6dc33 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 02 Feb 2012 17:25:19 +0200\r
+Message-ID: <m2d39xb6lc.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 02 Feb 2012 15:25:17 -0000\r
+\r
+On Thu, 02 Feb 2012 14:33:56 +0000, David Edmondson <dme@dme.org> wrote:\r
+> On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> > If this is really a problem, I vote for 1.  In general, I am not in\r
+> > favor of making the test suite more complicated than it needs to be.\r
+> \r
+> After listening to the debate, I agree. The documentation should state\r
+> that the order is 'expected actual' (or the other way around) and\r
+> offenders should be shot on sight^W^W^Wfixed.\r
+\r
+I've started to agree with Dmitry.\r
+\r
+Why do something that computer can do -- to guide test writers to\r
+give args in consistent order and provide suitable filenames.\r
+\r
+Secondly as the output files are provided for human consumption\r
+if there is consistent naming in expected output files helps \r
+developers getting parts of the big picture easier and finding \r
+right filenames easier.\r
+\r
+... and the reviewers doesn't need to keep their plasma guns\r
+handly.\r
+\r
+Tomi\r
+\r