Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.

diff --git a/04/9b98b6ffd91c33b75bd8bc6cf91b352ed42898 b/04/9b98b6ffd91c33b75bd8bc6cf91b352ed42898
new file mode 100644 (file)
index 0000000..f8ec769
--- /dev/null
+++ b/04/9b98b6ffd91c33b75bd8bc6cf91b352ed42898
@@ -0,0 +1,126 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5C3A1431FD0\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Jun 2011 22:10:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id vqxhk2cWlMg2 for <notmuch@notmuchmail.org>;\r
+       Wed,  1 Jun 2011 22:10:17 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id 73485431FB6\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Jun 2011 22:10:17 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 23A8929A4E5;\r
+       Wed,  1 Jun 2011 22:10:16 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 090CE54C02C; Wed,  1 Jun 2011 22:10:16 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.\r
+In-Reply-To: <1306619520-25730-15-git-send-email-jrollins@finestructure.net>\r
+References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-2-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-3-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-4-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-5-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-6-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-7-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-8-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-9-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-10-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-11-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-12-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-13-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-14-git-send-email-jrollins@finestructure.net>\r
+       <1306619520-25730-15-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 01 Jun 2011 22:10:07 -0700\r
+Message-ID: <874o48yg28.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 02 Jun 2011 05:10:18 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sat, 28 May 2011 14:51:49 -0700, Jameson Graef Rollins <jrollins@finestr=\r
+ucture.net> wrote:\r
+Hi Jamie,\r
+\r
+I've pushed the next few patches up to this point, (with only one\r
+functional change---I fixed a new test case to correctly use\r
+notmuch_search_sanitize to avoid spurious failures unmatching thread ID\r
+values).\r
+\r
+This patch, however, isn't ready. The big problem is in this commit\r
+message:\r
+\r
+> From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+>=20\r
+> In notmuch 0.5 notmuch-fcc-dirs style changed.  The previous code\r
+> did not correctly identify an old configuration and, as a\r
+> consequence, broke new configurations.\r
+\r
+There are several things there that are too vague, ("previous code",\r
+"old configuration", "new configurations"). What kind of configuration\r
+is broken? How does the change here help?\r
+\r
+It would be easier to understand the code if there were a corresponding\r
+test case for it. I'd even be willing to help write a test case, but\r
+there are not enough specifics in that commit message to even tell me\r
+what to test.\r
+\r
+>        ((and (listp notmuch-fcc-dirs)\r
+> -            (=3D 1 (length (car notmuch-fcc-dirs))))\r
+> +            (stringp (car notmuch-fcc-dirs)))\r
+\r
+So the "old configuration" was a single string? And this has been\r
+inadvertently broken since 0.5?\r
+\r
+>         ;; Old style - no longer works.\r
+>         (error "Invalid `notmuch-fcc-dirs' setting (old style)"))\r
+\r
+Yikes. That vague phrasing ("old style") is already in the code in error\r
+messages as well.\r
+\r
+Dmitry, can you help me know what's going on here? (Preferably by\r
+sending a newer commit with a more thorough commit message.)\r
+\r
+Thanks,\r
+\r
+=2DCarl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk3nGy8ACgkQ6JDdNq8qSWhjtgCgqoIcakwlAb/jkrpdX/gldWqb\r
+uykAn1jqk3hyOh0Vq/Pje1ubAoF84P4S\r
+=1ZcD\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r