Re: [PATCH v2 4/7] emacs: Use result text properties for search result iteration

diff --git a/02/84f89d57816296b327e0f1383ef28b4c7c3ce1 b/02/84f89d57816296b327e0f1383ef28b4c7c3ce1
new file mode 100644 (file)
index 0000000..c6a2312
--- /dev/null
+++ b/02/84f89d57816296b327e0f1383ef28b4c7c3ce1
@@ -0,0 +1,123 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 11183431FBD\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jul 2012 14:13:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fOPRzwQw4avJ for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Jul 2012 14:13:21 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2F7AF431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jul 2012 14:13:21 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id C4C2166E0024;\r
+       Sat, 14 Jul 2012 14:13:20 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (unknown [76.89.192.57])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id D981B66E00CC;\r
+       Sat, 14 Jul 2012 14:13:13 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 64AF443B; Sat, 14 Jul 2012 14:13:13 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH v2 4/7] emacs: Use result text properties for search\r
+       result iteration\r
+In-Reply-To: <20120714195003.GF31670@mit.edu>\r
+References: <1342140319-19859-1-git-send-email-amdragon@mit.edu>\r
+       <1342237406-32507-1-git-send-email-amdragon@mit.edu>\r
+       <1342237406-32507-5-git-send-email-amdragon@mit.edu>\r
+       <87d33yf8bi.fsf@servo.finestructure.net>\r
+       <20120714195003.GF31670@mit.edu>\r
+User-Agent: Notmuch/0.13.2+89~g9ab91ad (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 14 Jul 2012 14:13:11 -0700\r
+Message-ID: <874npaqc60.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Jul 2012 21:13:23 -0000\r
+\r
+--=-=-=\r
+\r
+On Sat, Jul 14 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> That's strange.  What was the error?\r
+>\r
+> I've been testing with\r
+>    (("date" . "%12s ")\r
+>     ("count" . "%-7s ")\r
+>     ("authors" . "%-20s ")\r
+>     ("subject" . "\n%s ")\r
+>     ("tags" . "(%s)"))\r
+> But maybe there are other cases it doesn't handle correctly?\r
+\r
+Hrm.  The error was:\r
+\r
+  error in process filter: wrong type argument: wholenump, -13\r
+\r
+However, that's in my test emacs setup.  It works fine in my normal\r
+emacs session.  Lets assume this is just a problem with my setup that\r
+I'll look into.\r
+\r
+The other problem I seem to be running into is that the\r
+customize-variable interface definitely doesn't handle newlines very\r
+well.  If I try to add a '\n' in the interface it gets escaped, so I end\r
+up with:\r
+\r
+     ("subject" . "\\n%s ")\r
+\r
+If I add the '\n' manually in my config, notmuch-search then interprets\r
+the string correctly and adds newlines to the search results, but then\r
+the customize-variable interface interprets the newline and adds a\r
+newline the string field that kind makes the interface a little weird.\r
+Is there "proper" way to add a newline to a string value in the\r
+customize-variable interface that I'm not aware of?\r
+\r
+In any event, this is in no way a blocker for this patch series.  This\r
+is all totally tangential.  The patch series is great.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJQAeDnAAoJEO00zqvie6q8aM0QAKi9MurNLAj271zbyBpiMQXX\r
+CE7VUEEfZVzD4xk/knTM5vCPurfqizqjiictSb7DEqHVjwtf3ypANgK4AC4NM6FB\r
+LOxZ3+WMnkO6s0wCbvz4P4BnGt4NhLZnqLQsdZ0igJbOeD7efRolxR1tEp6y+6H1\r
+JM8KjaJECTj3fjGceN83vXoBZBpJm6+/6FmvPRnM+1KfMEzEYxeq0kntarvX0fVP\r
+TJsgYIDexWsGdEWQ6gaBD+7EtB4fVwpPome3LQF8LqjcBmBT8QVveMy776h1Jhih\r
+4VMKTf6QBEEGU2LBp8VfIbej+Eb0/LgnkaBSg8WrdnR9VX7clZifRcVu+NZTWYpf\r
+KTlBy4jOQe3eSx43W2BlgPmEU9S1kNvHPLJs4LGgsvo2fI8G3kVVHrrEjF2HwtIu\r
+Z8hEnopFDmssXZzfSgyy79FVHMsb9ESNbKshiZEHEKxn1BbF9aPiTlWj7jnUeRdE\r
+paHHDDeWFknQvNOlU/5G6i17xpmMz+nSZ20kIg/VOMFH2mOm7LQJUgiN2/l3M9Ky\r
+KlZ8eam6RJCDMqEjBDmEnF3O2Tn3RU+OAucXO2YYb8KcOOaPbn9gctznxwBzl7ll\r
+W2dGRk3n1xf3zYKdmNE/WMlHjbtb7O5KBZrp63ZfRcFbARWBmEp4V4apTi4qqZA8\r
+YswBM/e/D9Z6oXmMw1zZ\r
+=Tgpu\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r