Re: Bug?: notmuch-search-show-thread shows several threads; only one containing match...

diff --git a/90/8cfc2cacc89acd40d6c2f29d0120402028ffcd b/90/8cfc2cacc89acd40d6c2f29d0120402028ffcd
new file mode 100644 (file)
index 0000000..ba5f620
--- /dev/null
+++ b/90/8cfc2cacc89acd40d6c2f29d0120402028ffcd
@@ -0,0 +1,117 @@
+Return-Path: <error4me@gmx.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 23D61431E64\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 14:34:53 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.001\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.001 tagged_above=-999 required=5\r
+       tests=[FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id pUkjvp6Eu71I for <notmuch@notmuchmail.org>;\r
+       Mon, 30 Jan 2012 14:34:52 -0800 (PST)\r
+Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.23])\r
+       by olra.theworths.org (Postfix) with SMTP id 2F86D431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 14:34:52 -0800 (PST)\r
+Received: (qmail invoked by alias); 30 Jan 2012 22:34:50 -0000\r
+Received: from p54BE2F5E.dip.t-dialin.net (EHLO shi.workgroup) [84.190.47.94]\r
+       by mail.gmx.net (mp029) with SMTP; 30 Jan 2012 23:34:50 +0100\r
+X-Authenticated: #19296480\r
+X-Provags-ID: V01U2FsdGVkX19n+fUZ8Z1niSsF2IzcN6zH1DAPYhfk0+/l89pzWr\r
+       7rViV5HJfs308X\r
+Received: from grfz by shi.workgroup with local (Exim 4.77)\r
+       (envelope-from <error4me@gmx.de>)\r
+       id 1Rrzo4-0000l4-RS; Mon, 30 Jan 2012 23:34:36 +0100\r
+Date: Mon, 30 Jan 2012 23:34:16 +0100\r
+From: Gregor Zattler <telegraph@gmx.net>\r
+To: notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: Bug?: notmuch-search-show-thread shows several threads; only one\r
+       containing matching messages\r
+Message-ID: <20120130223416.GA26239@shi.workgroup>\r
+Mail-Followup-To: notmuch <notmuch@notmuchmail.org>\r
+References: <20120126004024.GA13704@shi.workgroup>\r
+       <20120126011903.GA1176@mit.edu>\r
+       <8762fzry7k.fsf@servo.finestructure.net>\r
+       <20120126124450.GB30209@shi.workgroup> <87mx9avbc1.fsf@praet.org>\r
+       <20120129234213.GB11460@shi.workgroup> <87zkd5655g.fsf@praet.org>\r
+       <20120130190425.GB13521@shi.workgroup> <878vkoev95.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <878vkoev95.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Y-GMX-Trusted: 0\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 22:34:53 -0000\r
+\r
+Hi Mark,\r
+* Mark Walters <markwalters1009@gmail.com> [30. Jan. 2012]:\r
+> On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler <telegraph@gmx.net> wrote:\r
+>> * Pieter Praet <pieter@praet.org> [30. Jan. 2012]:\r
+>>> On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler <telegraph@gmx.net> wrote:\r
+>>>> * Pieter Praet <pieter@praet.org> [26. Jan. 2012]:\r
+>>>>> Here's another couple of threads squashed into a single one:\r
+>>>>> - [O] [Use Question] Capture and long lines\r
+>>>>>   - id:"BANLkTikoF4tXuNLLufRzNSD6k2ZYs7sUcg@mail.gmail.com"\r
+>>>>> - [O] Worg update\r
+>>>>>   - id:"m1wrfiz3ch.fsf@tsdye.com"\r
+>>>>> - [O] Table formula to convert hex to dec\r
+>>>>>   - id:"20110724080054.GB16388@x201"\r
+>>>>> - [O] ICS import?\r
+>>>>>   - id:"20120125173421.GQ3747@x201"\r
+>>>>> \r
+>>>>> \r
+>>>>> AFAICT, none of them share Message-Id's...\r
+>>>> \r
+>>>> Do you consider this a bug?\r
+>>>> \r
+>>> \r
+>>> I do.  No idea what causes it or how to fix it though... :)\r
+>> \r
+>> First I thougt it' not a severe bug since one see's more not less\r
+>> messages in notmuch show buffer.  But later I realised one also\r
+>> sees less not more threads in notmuch search buffer and might not\r
+>> read certain notmuch threads because of "wrong" $Subject: in\r
+>> notmuch search buffer.\r
+\r
+> I think notmuch links two messages into the same thread if they have an\r
+> in-reply-to or reference header in common: i.e the messages reference a\r
+> common parent message.  (See comment in lib/database.cc "Even before a\r
+> message is added, it's pre-allocated thread ID is useful so that all\r
+> descendant messages that reference this common parent can be recognized\r
+> as belonging to the same thread.")\r
+\r
+So in case message a from thread A and message b from B would\r
+name the same Message c in their In-Reoply-To:/References:\r
+headers, while c is not (for some reason) in A or B, notmuch\r
+would assume both threads linked?  Makes sense.\r
+ \r
+> As far as I can see your grep tests haven't checked for that. \r
+\r
+True.\r
+\r
+> Also, could you email me the mbox you had (I think you said that it was\r
+> a mailing list so all public) and I will take a look?\r
+\r
+Sure, I do so off-list because of the size of the attachment.\r
+\r
+\r
+Ciao, Gregor\r
+-- \r
+ -... --- .-. . -.. ..--.. ...-.-\r