Re: [notmuch] [PATCH] Simplify "unread" tag handling in emacs UI.

diff --git a/ad/1ac2f514b5390ebdc20b738763e22f9653b74a b/ad/1ac2f514b5390ebdc20b738763e22f9653b74a
new file mode 100644 (file)
index 0000000..31d13de
--- /dev/null
+++ b/ad/1ac2f514b5390ebdc20b738763e22f9653b74a
@@ -0,0 +1,97 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3F5CE431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Feb 2010 10:26:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.519\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.519 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1.8, AWL=0.391, BAYES_05=-1.11] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ViLbhHeGDmsS; Wed, 24 Feb 2010 10:26:50 -0800 (PST)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7E323431FAE;\r
+       Wed, 24 Feb 2010 10:26:50 -0800 (PST)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id D51DB25427B; Wed, 24 Feb 2010 10:26:47 -0800 (PST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Sebastian Spaeth <Sebastian@SSpaeth.de>, Jameson Rollins\r
+       <jrollins@finestructure.net>, Notmuch Mail list <notmuch@notmuchmail.org>\r
+In-Reply-To: <87ljes0yy0.fsf@SSpaeth.de>\r
+References: <87ska1vh7r.fsf@servo.finestructure.net>\r
+       <87ljes0yy0.fsf@SSpaeth.de>\r
+Date: Wed, 24 Feb 2010 10:26:47 -0800\r
+Message-ID: <87vddmwkuw.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Subject: Re: [notmuch] [PATCH] Simplify "unread" tag handling in emacs UI.\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Feb 2010 18:26:51 -0000\r
+\r
+--=-=-=\r
+\r
+On Wed, 17 Feb 2010 14:33:11 +0100, "Sebastian Spaeth" <Sebastian@SSpaeth.de> wrote:\r
+> On Tue, 19 Jan 2010 17:54:16 -0500, Jameson Rollins <jrollins@finestructure.net> wrote:\r
+> > This patch is intended to greatly simplify the handling of the\r
+> > "unread" tag in the emacs UI.  This patch adds a new function\r
+> > 'notmuch-show-mark-read', that removes the "unread" tag in\r
+> > notmuch-show-mode.  This function is then executed as a\r
+> > notmuch-show-hook, and by notmuch-show-next-message.  All of the\r
+> > functions that explicitly marked messages as unread are removed or\r
+> > renamed.\r
+\r
+Hi Jameson,\r
+\r
+Thanks for contributing the patch. This exact feature, (removing all\r
+commands with "and mark read" in their names), has been on my todo list\r
+for too long, and I'm anxious to remove it from that. But...\r
+\r
+> It then checks the unread status in order to decide whether to proceed\r
+> to the next again. So with your patch notmuch-show-next-unread-message\r
+> will skip through all messages in a thread thinking they are all read\r
+> (and actually marking all as read).\r
+\r
+...that seems like a fatal bug in this script. Thanks for noting that\r
+Sebastian.\r
+\r
+I'm very interested in augmenting the test suite such that we could\r
+write emacs-based tests that would capture this bug. It seems that with\r
+the --batch, --load, and --funcall options it shouldn't be too hard to\r
+write a modular function exercising emacs code and then execute it\r
+no-interactively. Then we could either inspect the state of the database\r
+to ensure the operation worked as desired, or else have the test\r
+function write a buffer out to a file and test that the file has the\r
+desired contents.\r
+\r
+So that's something I'll be working on soon. And of course, I'll always\r
+be glad to accept any help.\r
+\r
+-Carl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFLhW9n6JDdNq8qSWgRAg1SAJ42ckxe1mjQ8EGtTYY4F82oppri8gCeL8vx\r
+TAWYawtFdqm0VCPVvUzww/k=\r
+=3Ud/\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r