Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id...

diff --git a/24/e97003aeb8b844225955cb26da9ea4e2db61f3 b/24/e97003aeb8b844225955cb26da9ea4e2db61f3
new file mode 100644 (file)
index 0000000..dc12d02
--- /dev/null
+++ b/24/e97003aeb8b844225955cb26da9ea4e2db61f3
@@ -0,0 +1,98 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 59729429E31\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:21:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id gvvyZ6GP4BXJ for <notmuch@notmuchmail.org>;\r
+       Thu, 12 Jan 2012 09:21:54 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ B7FD5429E29   for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:21:53 -0800\r
+ (PST)\r
+Received: by wgbds11 with SMTP id ds11so1959821wgb.2\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 09:21:52 -0800 (PST)\r
+Received: by 10.180.14.161 with SMTP id q1mr2066499wic.1.1326388912568;\r
+       Thu, 12 Jan 2012 09:21:52 -0800 (PST)\r
+Received: from localhost ([109.131.126.209])\r
+       by mx.google.com with ESMTPS id o1sm5552156wbh.9.2012.01.12.09.21.51\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 12 Jan 2012 09:21:51 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in\r
+       buttonised id: links\r
+In-Reply-To: <1324616352-15337-1-git-send-email-jrollins@finestructure.net>\r
+References: <1324616352-15337-1-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Thu, 12 Jan 2012 18:20:12 +0100\r
+Message-ID: <874nw0ltwz.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 12 Jan 2012 17:21:54 -0000\r
+\r
+On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> Since message-ids necessarily match just a single message, there's no\r
+> reason to do a search for the id before viewing the actual message;\r
+> the search just becomes an extra screen to click through.  Clicking on\r
+> an id: links now just jumps straight to the message itself.\r
+> ---\r
+> This just fixes the subject of the patch, which had a typo.  Sorry.\r
+> \r
+>  emacs/notmuch-show.el |    2 +-\r
+>  1 files changed, 1 insertions(+), 1 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 98db8f2..623d521 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -803,7 +803,7 @@ a corresponding notmuch search."\r
+>        (remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)\r
+>        (make-text-button (match-beginning 0) (match-end 0)\r
+>                      'action `(lambda (arg)\r
+> -                               (notmuch-search ,(match-string-no-properties 0)))\r
+> +                               (notmuch-show ,(match-string-no-properties 0)))\r
+>                      'follow-link t\r
+>                      'help-echo "Mouse-1, RET: search for this message"\r
+>                      'face goto-address-mail-face))))\r
+> -- \r
+> 1.7.7.3\r
+\r
+Anti-RSI FTW!\r
+\r
+However...  If no message with that id: exists, `notmuch-show'\r
+will drop us to a blank screen.\r
+\r
+See id:"87lisjzrsc.fsf@kepler.schwinge.homeip.net" for some mock\r
+'id:' links which demonstrate this nicely.\r
+\r
+Patches follow.\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r