Re: random corpus generator, v3

diff --git a/1d/372ad900ca69475fc1c86071ffab24e3700137 b/1d/372ad900ca69475fc1c86071ffab24e3700137
new file mode 100644 (file)
index 0000000..78ba882
--- /dev/null
+++ b/1d/372ad900ca69475fc1c86071ffab24e3700137
@@ -0,0 +1,118 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 69535431FBD\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Oct 2012 21:16:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 3sWO-HQio54b for <notmuch@notmuchmail.org>;\r
+       Fri, 19 Oct 2012 21:16:37 -0700 (PDT)\r
+Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com\r
+       [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id EA479431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Oct 2012 21:16:36 -0700 (PDT)\r
+Received: by mail-vb0-f53.google.com with SMTP id fc21so1295322vbb.26\r
+       for <notmuch@notmuchmail.org>; Fri, 19 Oct 2012 21:16:35 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=bTFs2kAeBpxqC1RkvGm1jgf/TvXePxGqdeQm5/4rUkc=;\r
+       b=oAo+EcEJeXzUMdeDItR+PCPeMkAtiVrmS87SMJi7H+nhFvpOP6ElCYsw1pfSiEMdXh\r
+       27BEtNrJawc6640yBtpN1XYHCK1tb2M0WfASzYk004lVVprSfrOIqiVagKEduOhg6WSx\r
+       x4qt7DtcIURZ9VTOQm1y0TTRvhfUOgRpjW95zRU0VnHw8GID68XkLFOsS41sdPUpaM9j\r
+       Act8DfFwbEI02S/fp3qZ7jrU41sHru4VpRBx42oqifrJ+FpgxF7pYRJJ91ut7FbFB6OZ\r
+       LoEwE6l3CfsnCLVmWIzbxANBu3m2Cp9UgDhXBqwgYlO/sFHcVnKPVkseNkHViAqNQbah\r
+       kA6w==\r
+Received: by 10.52.29.138 with SMTP id k10mr3478866vdh.53.1350706595182;\r
+       Fri, 19 Oct 2012 21:16:35 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id y15sm3429713vdt.9.2012.10.19.21.16.33\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Fri, 19 Oct 2012 21:16:34 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: random corpus generator, v3\r
+In-Reply-To: <1345382314-5330-1-git-send-email-david@tethera.net>\r
+References: <1345382314-5330-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 20 Oct 2012 00:16:32 -0400\r
+Message-ID: <871ugt7p7j.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 20 Oct 2012 04:16:37 -0000\r
+\r
+david@tethera.net writes:\r
+\r
+> This obsoletes the series at:\r
+>\r
+>      id:"1344888831-4301-1-git-send-email-bremner@debian.org"\r
+>\r
+> Changes since v2:\r
+>\r
+> - clean up new test-binaries and objects\r
+>\r
+> - remove the "set -o pipefail" leftover from debugging.  Possibly this\r
+>   makes sense as a global setting, but in a seperate patch.\r
+>\r
+> - add hex-escape to test/basic\r
+>\r
+> - rebase against updated master.\r
+\r
+Hi! This looks pretty good to me and I am for improving the test\r
+infrastructure.\r
+\r
+Some minor problems:\r
+\r
+- Patch 2 doesn't apply; neither do patches 4 or 5, presumably due to changes\r
+  that weren't made due to patch 2.\r
+\r
+- Commit message discipline: the subject line of patch 4 ends in a\r
+  period. "Seperate" is spelled by most people as "separate", though I\r
+  would encourage you to buck the trend if you are so inclined.\r
+\r
+- In patch 4:\r
+\r
+> +    if (private_status == NOTMUCH_PRIVATE_STATUS_NO_DOCUMENT_FOUND) {\r
+> +       _notmuch_message_add_term (message, "type", "mail");\r
+> +    } else {\r
+> +       return NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID;\r
+> +    }\r
+\r
+Why not switch the branches? That is, check for private_status !=\r
+NOTMUCH_PRIVATE_STATUS_NO_DOCUMENT_FOUND and return immediately?\r
+\r
+- In patch 5:\r
+\r
+> +    for (count = 0; count < num_messages; count++) {\r
+> +    int j;\r
+> +    int num_tags = random () % (max_tags + 1);\r
+> +    int this_mid_len = random () % message_id_len + 1;\r
+\r
+This looks odd. I'm pretty sure it's correct, but my brain keeps saying,\r
+"Why are there no parentheses on (message_id_len + 1)?" Maybe just a\r
+comment that message ids must be at least one character long, or the\r
+ranges of values necessary for both of these variables.\r
+\r
+Ethan\r