--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id DE3C5429E29\r
+ for <notmuch@notmuchmail.org>; Thu, 24 May 2012 15:01:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id XbRHno5qo8Hi for <notmuch@notmuchmail.org>;\r
+ Thu, 24 May 2012 15:01:29 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
+ [18.9.25.14])\r
+ by olra.theworths.org (Postfix) with ESMTP id 26340431E84\r
+ for <notmuch@notmuchmail.org>; Thu, 24 May 2012 15:01:23 -0700 (PDT)\r
+X-AuditID: 1209190e-b7fd86d0000008b4-a3-4fbeafb32bc3\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+ by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 74.77.02228.3BFAEBF4; Thu, 24 May 2012 18:01:23 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q4OM1N5B021199; \r
+ Thu, 24 May 2012 18:01:23 -0400\r
+Received: from drake.mit.edu (26-4-163.dynamic.csail.mit.edu [18.26.4.163])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4OM1MrS009166\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Thu, 24 May 2012 18:01:23 -0400 (EDT)\r
+Received: from amthrax by drake.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1SXg5w-00064c-I9; Thu, 24 May 2012 18:01:20 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v4 4/4] new: Unify add_files and add_files_recursive\r
+Date: Thu, 24 May 2012 18:01:13 -0400\r
+Message-Id: <1337896873-23253-5-git-send-email-amdragon@mit.edu>\r
+X-Mailer: git-send-email 1.7.10\r
+In-Reply-To: <1337896873-23253-1-git-send-email-amdragon@mit.edu>\r
+References: <1337887922-13163-1-git-send-email-amdragon@mit.edu>\r
+ <1337896873-23253-1-git-send-email-amdragon@mit.edu>\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsUixG6nort5/T5/g1uLtCyu35zJ7MDo8WzV\r
+ LeYAxigum5TUnMyy1CJ9uwSujAebp7AWPOGruHl7LlsD41PuLkZODgkBE4mGnqXMELaYxIV7\r
+ 69m6GLk4hAT2MUqsPrQQytnAKHH43D5GCOc4k8Scdw/YIZxZjBKnT9xlAelnE9CQ2LZ/OSOI\r
+ LSIgLbHz7mzWLkYODmYBNYk/XSogYWEBF4mPa1+ClbMIqEps2tbBBmLzCjhIvPk5jQniDHmJ\r
+ p/f7wOKcAo4Sj8/+AhspJFAucfnGXJYJjPwLGBlWMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Rrr\r
+ 5WaW6KWmlG5iBIUNpyTfDsavB5UOMQpwMCrx8LJE7/MXYk0sK67MPcQoycGkJMr7YzVQiC8p\r
+ P6UyI7E4I76oNCe1+BCjBAezkgivYCRQjjclsbIqtSgfJiXNwaIkzrtKc7e/kEB6Yklqdmpq\r
+ QWoRTFaGg0NJgvfgOqBGwaLU9NSKtMycEoQ0EwcnyHAeoOH660GGFxck5hZnpkPkTzEqSonz\r
+ PgFpFgBJZJTmwfXC4voVozjQK8K830GqeIApAa77FdBgJqDBWx7vBRlckoiQkmpgnL0+pzH5\r
+ gZbelNaTG0rM9bs/GC63Mvp/VU1/h4jV9H0HZ767FOWl9j+T4dr8jLrAlZfeN2xaHdHisU1N\r
+ xna6pPLZDy+1Gaf1J+UwKpmZvX5WHlVpv9tp/8IprE4rLqlITuz+1J/72mN+Kg+LE6tVXMpT\r
+ xfCgTmFHwcS4H1/9Zt8rEWubmlusxFKckWioxVxUnAgAdjcpJMYCAAA=\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 24 May 2012 22:01:31 -0000\r
+\r
+Since starting at the top of a directory tree and recursing within\r
+that tree are now identical operations, there's no need for both\r
+add_files and add_files_recursive. This eliminates add_files (which\r
+did nothing more than call add_files_recursive after the previous\r
+patch) and renames add_files_recursive to add_files.\r
+---\r
+ notmuch-new.c | 18 ++++--------------\r
+ 1 file changed, 4 insertions(+), 14 deletions(-)\r
+\r
+diff --git a/notmuch-new.c b/notmuch-new.c\r
+index 2b05605..938ae29 100644\r
+--- a/notmuch-new.c\r
++++ b/notmuch-new.c\r
+@@ -281,9 +281,9 @@ _entry_in_ignore_list (const char *entry, add_files_state_t *state)\r
+ * if fs_mtime isn't the current wall-clock time.\r
+ */\r
+ static notmuch_status_t\r
+-add_files_recursive (notmuch_database_t *notmuch,\r
+- const char *path,\r
+- add_files_state_t *state)\r
++add_files (notmuch_database_t *notmuch,\r
++ const char *path,\r
++ add_files_state_t *state)\r
+ {\r
+ DIR *dir = NULL;\r
+ struct dirent *entry = NULL;\r
+@@ -377,7 +377,7 @@ add_files_recursive (notmuch_database_t *notmuch,\r
+ }\r
+ \r
+ next = talloc_asprintf (notmuch, "%s/%s", path, entry->d_name);\r
+- status = add_files_recursive (notmuch, next, state);\r
++ status = add_files (notmuch, next, state);\r
+ if (status) {\r
+ ret = status;\r
+ goto DONE;\r
+@@ -647,16 +647,6 @@ stop_progress_printing_timer (void)\r
+ }\r
+ \r
+ \r
+-/* This is the top-level entry point for add_files. It does a couple\r
+- * of error checks and then calls into the recursive function. */\r
+-static notmuch_status_t\r
+-add_files (notmuch_database_t *notmuch,\r
+- const char *path,\r
+- add_files_state_t *state)\r
+-{\r
+- return add_files_recursive (notmuch, path, state);\r
+-}\r
+-\r
+ /* XXX: This should be merged with the add_files function since it\r
+ * shares a lot of logic with it. */\r
+ /* Recursively count all regular files in path and all sub-directories\r
+-- \r
+1.7.10\r
+\r
projects / notmuch-archives.git / commitdiff