Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

diff --git a/39/499b2b76a35c014bb2ae35666224df716ad297 b/39/499b2b76a35c014bb2ae35666224df716ad297
new file mode 100644 (file)
index 0000000..0637de3
--- /dev/null
+++ b/39/499b2b76a35c014bb2ae35666224df716ad297
@@ -0,0 +1,85 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0FCE0431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 20:12:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id LXM0nDgIEHcj for <notmuch@notmuchmail.org>;\r
+       Mon, 15 Oct 2012 20:12:55 -0700 (PDT)\r
+Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com\r
+       [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 639B2431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 20:12:55 -0700 (PDT)\r
+Received: by mail-qc0-f181.google.com with SMTP id x40so5296673qcp.26\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 20:12:54 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=TE0+Y5vnaQhISMV3QVY3YWrNJyEOR4nldJh5TfQg7l8=;\r
+       b=jXMdJs924v1Rh21dqRsPs0jASVh9YlJdXVBEx+NY4IHdz4EBDLunPD/WpaHQP0sFPH\r
+       4ilg+AXhu9Q4SBR04T9zu9pSihCjcK8a6Y4RTgri4EgGvUlz2k8McElGgHXk1AM8vWYI\r
+       SbP2XixmtwiX3UGVGy/eKwJ3nb1pLwEHZnrY1ZYSWMSc4gkmJxdHDp+HqTB36KE6pk/m\r
+       aAd7cH2Ti+yBs66/KUlfNZ4cuUciTKTpRuPE7wVUzK9Tiyno20yyhJsYD7/q7qhf9MwQ\r
+       s/4n0bJ550Nv4KAZg7BvZDavvSLHUXe7Yf0MGbixWvjc6lZfUm31MkuCfsDQilo+BPTZ\r
+       ZvMQ==\r
+Received: by 10.229.136.81 with SMTP id q17mr6478714qct.115.1350357174872;\r
+       Mon, 15 Oct 2012 20:12:54 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id ch3sm17337002qab.9.2012.10.15.20.12.53\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 15 Oct 2012 20:12:54 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Mark Walters <markwalters1009@gmail.com>, Pieter Praet <pieter@praet.org>,\r
+       David Bremner <david@tethera.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{,\r
+       -search}'\r
+In-Reply-To: <87sjh2wx8z.fsf@qmul.ac.uk>\r
+References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>\r
+       <1330122640-18895-1-git-send-email-pieter@praet.org>\r
+       <1330122640-18895-6-git-send-email-pieter@praet.org>\r
+       <87sjh2wx8z.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 15 Oct 2012 23:12:51 -0400\r
+Message-ID: <87k3ur85zg.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 16 Oct 2012 03:12:59 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> I like the use of separator rather than hard-wiring " or ". My personal\r
+> preference would be to make that change but keep the two functions\r
+> separate (my "C"ness makes me like functions that have clear return\r
+> types!) But I am happy with the change too.\r
+\r
+I agree with this comment. Especially in dynamic languages, it's a good\r
+idea for each function to have only one return type.\r
+\r
+Also, it seems that the commit message has a TAB character in it (",<TAB>-search").\r
+\r
+Ethan\r