bug in configure script

diff --git a/12/3f39a135ae6be945f12ae25854e5c2cf90b3f1 b/12/3f39a135ae6be945f12ae25854e5c2cf90b3f1
new file mode 100644 (file)
index 0000000..23a93f2
--- /dev/null
+++ b/12/3f39a135ae6be945f12ae25854e5c2cf90b3f1
@@ -0,0 +1,121 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 84A3C431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  1 Jun 2012 11:17:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kTEcpI3dKWfh for <notmuch@notmuchmail.org>;\r
+       Fri,  1 Jun 2012 11:17:11 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id EE2E2431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  1 Jun 2012 11:17:10 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id A92D266E011D\r
+       for <notmuch@notmuchmail.org>; Fri,  1 Jun 2012 11:17:10 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (DHCP-123-229.caltech.edu [131.215.123.229])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id DA56766E0174\r
+       for <notmuch@notmuchmail.org>; Fri,  1 Jun 2012 11:17:08 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id C4D7014F; Fri,  1 Jun 2012 11:17:07 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: bug in configure script\r
+User-Agent: Notmuch/0.13+24~g16915cd (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 01 Jun 2012 11:17:05 -0700\r
+Message-ID: <87pq9ivqvy.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 01 Jun 2012 18:17:11 -0000\r
+\r
+--=-=-=\r
+\r
+There's a bug in the configure script that is causing auto-reruns of\r
+./configure to not inherit original command line options if there was\r
+more than one.  For instance, if I run:\r
+\r
+./configure --with-gmime-version=2.4 --prefix=/home/jrollins/opt/notmuch\r
+\r
+Then in Makefile.config I get:\r
+\r
+configure_options = --with-gmime-version=2.4--prefix=/home/jrollins/opt/notmuch\r
+\r
+This means that auto-reruns of configure will not get the proper\r
+options.\r
+\r
+I tracked this down to an issue with IFS and /bin/sh.  The first line of\r
+./configure is:\r
+\r
+readonly DEFAULT_IFS=$IFS\r
+\r
+DEFAULT_IFS is then used to reset IFS after it is modified within the\r
+script.  The problem is that /bin/sh is setting DEFAULT_IFS to be NULL\r
+(i.e. ''), which leads to no separation between variables when "$@" is\r
+expanded (which is itself problematic since I don't think "@" should use\r
+the IFS when expanded).  So this might be a bug in dash.  I don't know.\r
+In any event we need to fix this somehow.  I see two obvious solutions:\r
+\r
+* use /bin/bash.  This a one line diff that fixes the problem\r
+  immediately.\r
+\r
+* replace:\r
+\r
+    IFS=$DEFAULT_IFS\r
+\r
+  with:\r
+\r
+    unset IFS\r
+\r
+  Unsetting IFS also resets IFS to the default, without going through\r
+  this intermediate step.\r
+\r
+I'm ok with either solution, but I'll wait for some feedback since I\r
+imagine someone will have an opinion.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPyQchAAoJEO00zqvie6q8VlEP/AkYhn/YzNpESily/3dO1lfO\r
++XLDopIpGAI8Uf49T5MfPlWDRo/HGT1V85O+uZJrCT4Y4V6jxxbGxiejuZUUVQsA\r
+gwcW0V34M0BN9kyDbJhjA/VUQcIt0gbG4NYo71hwS6fFMItjDIOZXc46WirLiueS\r
+6SWcThQExzc6TXjtHkdhbaMhF0gTBslh+rrBO94SXJSyu7xlRTBUUG2ZBMlODEhw\r
+xdzWiGiQAeOpLmYmMGWKZrVgBJxMorF1TOgvoBGiXoK/fJVoyTGjAPn0B9E5a3V0\r
+sVdJAOgJHLnvsKL9vgJA1KdWXw80JWYfqI8FLXCrdq2TQArT/lBtpJ+B9d7DfTES\r
+Uk+uo5pu+X/DpBShBwYPFtLuILoVyuPzvdcDXoDT4PRuaIIPn5MyjwKA7bDIW4lv\r
+rjJ5ZZWrL3OWh5uXXN0i3wxc9XNgOFtPhRXhTiCTAmn4dU+FQC4I9/9oc0m+pRQm\r
+1K9OH9U0sIMinXksEBxtrF9ZHFUE6SEtejnb4j1jL/VrxRaKIvkbDtvBrue053ve\r
+R9XdcN5tpkqzDrKB6sM6ZMt1tQqPawigOTr5Ed1lxMgRl268ErncdX6Xe5fcnxB3\r
+03pBYYwSPgMt+7JpN3U79Lqi/4mSjBF8zKxkVZzVwKauooZDMdWl48LOTdSe0q56\r
+PgCyxPuqf25rK05l2PWN\r
+=1jlW\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r