Re: [PATCH 0/4] Maildir synchronization v2

diff --git a/81/e078070cdd1ac7ab6d0152ecb520ef12f9a58f b/81/e078070cdd1ac7ab6d0152ecb520ef12f9a58f
new file mode 100644 (file)
index 0000000..4c33aa7
--- /dev/null
+++ b/81/e078070cdd1ac7ab6d0152ecb520ef12f9a58f
@@ -0,0 +1,92 @@
+Return-Path: <pioto@pioto.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1354940D144\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Oct 2010 06:32:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.9\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5\r
+       tests=[BAYES_00=-1.9] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id sFj2iLZEOpGX for <notmuch@notmuchmail.org>;\r
+       Wed, 13 Oct 2010 06:32:03 -0700 (PDT)\r
+Received: from everglades.pioto.org (mail.pioto.org [207.192.71.235])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9451740D141\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Oct 2010 06:32:03 -0700 (PDT)\r
+Received: from pioto.org (pit84.pair.com [216.92.130.84])\r
+       (Authenticated sender: pioto)\r
+       by everglades.pioto.org (Postfix) with ESMTPSA id 0C4CB1601D1\r
+       for <notmuch@notmuchmail.org>; Wed, 13 Oct 2010 09:32:02 -0400 (EDT)\r
+Date: Wed, 13 Oct 2010 09:31:58 -0400\r
+From: Mike Kelly <pioto@pioto.org>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/4] Maildir synchronization v2\r
+Message-ID: <20101013093158.6d637b89@pioto.org>\r
+In-Reply-To: <1286972038-21064-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1286972038-21064-1-git-send-email-sojkam1@fel.cvut.cz>\r
+X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.7; i386-portbld-freebsd8.0)\r
+Mime-Version: 1.0\r
+Content-Type: text/plain; charset=US-ASCII\r
+Content-Transfer-Encoding: 7bit\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 13 Oct 2010 13:32:14 -0000\r
+\r
+On Wed, 13 Oct 2010 14:13:54 +0200\r
+Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> Hi,\r
+> \r
+> this is an updated version of patches sent in\r
+> id:1273580061-22580-1-git-send-email-sojkam1@fel.cvut.cz. Only the\r
+> last patch (tests) was actually updated to work with new test suite.\r
+> These patches has already been tested by several people and I think\r
+> they are ready to be merged. They can be pulled by:\r
+> \r
+> git pull git://rtime.felk.cvut.cz/notmuch maildir-sync-v2\r
+\r
+This sounds like just the sort of feature set I'd want from this sort\r
+of patch, except unfortunately it won't compile for me on FreeBSD:\r
+\r
+  gcc -c -DNOTMUCH_VERSION=0.3.1-96-g6e0dca9 -O2 -Wall -Wextra -Wwrite-strings -Wswitch-enum -Wmissing-declarations -DHAVE_GETLINE=1 -D_REENTRANT -I/usr/local/include/gmime-2.4 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include   -I/usr/local/include   -DHAVE_VALGRIND=0  -DHAVE_STRCASESTR=1  -Icompat -Ilib -fPIC notmuch-config.c -o notmuch-config.o\r
+  notmuch-config.c:90: error: field 'maildir_sync' has incomplete type\r
+  notmuch-config.c: In function 'notmuch_config_open':\r
+  notmuch-config.c:241: error: 'NOTMUCH_MAILDIR_SYNC_INVALID' undeclared (first use in this function)\r
+  notmuch-config.c:241: error: (Each undeclared identifier is reported only once\r
+  notmuch-config.c:241: error: for each function it appears in.)\r
+  notmuch-config.c:335: error: invalid use of undefined type 'enum notmuch_maildir_sync'\r
+  notmuch-config.c:336: error: 'NOTMUCH_MAILDIR_SYNC_NONE' undeclared (first use in this function)\r
+  notmuch-config.c:336: error: type of formal parameter 2 is incomplete\r
+  notmuch-config.c: At top level:\r
+  notmuch-config.c:596: error: return type is an incomplete type\r
+  notmuch-config.c:596: error: conflicting types for 'notmuch_config_get_maildir_sync'\r
+  notmuch-client.h:195: error: previous declaration of 'notmuch_config_get_maildir_sync' was here\r
+  notmuch-config.c: In function 'notmuch_config_get_maildir_sync':\r
+  notmuch-config.c:597: error: 'NOTMUCH_MAILDIR_SYNC_INVALID' undeclared (first use in this function)\r
+  notmuch-config.c:602: warning: 'return' with a value, in function returning void\r
+  notmuch-config.c: At top level:\r
+  notmuch-config.c:607: error: parameter 2 ('maildir_sync') has incomplete type\r
+  notmuch-config.c: In function 'notmuch_config_set_maildir_sync':\r
+  notmuch-config.c:607: warning: unused parameter 'maildir_sync'\r
+  gmake: *** [notmuch-config.o] Error 1\r
+\r
+This is with "gcc (GCC) 4.2.1 20070719  [FreeBSD]"\r
+\r
+Switching to gcc44 seems to allow it to compile correctly, however notmuch didn't used to have that dependency.\r
+\r
+-- \r
+Mike Kelly\r