Re: [PATCH v1] emacs: `with-current-notmuch-show-message' should not leak `coding...

diff --git a/20/20816f8978ef928cfddffe2cccaa0c6592fba6 b/20/20816f8978ef928cfddffe2cccaa0c6592fba6
new file mode 100644 (file)
index 0000000..701fdd5
--- /dev/null
+++ b/20/20816f8978ef928cfddffe2cccaa0c6592fba6
@@ -0,0 +1,101 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8E8DF431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 19 Nov 2014 03:07:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DN-ljETRdh+D for <notmuch@notmuchmail.org>;\r
+       Wed, 19 Nov 2014 03:07:05 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 828E4431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 19 Nov 2014 03:07:05 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 169BD1000C1;\r
+       Wed, 19 Nov 2014 13:06:51 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v1] emacs: `with-current-notmuch-show-message' should not\r
+       leak    `coding-system-for-read'\r
+In-Reply-To: <1416294197-3170-1-git-send-email-dme@dme.org>\r
+References: <1416294197-3170-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 19 Nov 2014 13:06:50 +0200\r
+Message-ID: <m2389fsb3p.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 19 Nov 2014 11:07:13 -0000\r
+\r
+On Tue, Nov 18 2014, David Edmondson <dme@dme.org> wrote:\r
+\r
+> `with-current-notmuch-show-message' applies a `no-conversion' coding\r
+> system when reading a raw message from notmuch. That coding system\r
+> should _not_ be applied when the body of the macro is evaluated, as it\r
+> can cause file operations used during that evaluation to incorrectly\r
+> apply the `no-conversion' coding system.\r
+>\r
+> This was discovered when a user's .signature file contained non-ASCII\r
+> characters. When a message is forwarded, the `no-conversion' coding\r
+> system was applied to the reading of the .signature file, resulting in\r
+> raw rather than UTF-8 interpretation of the data.\r
+> ---\r
+\r
+Uh, this looks as good as it can be ;), and tests pass, +1\r
+\r
+Tomi\r
+\r
+\r
+\r
+>\r
+> Fix for id:87ioifb55d.fsf@nautilus.nautilus.\r
+>\r
+>  emacs/notmuch-show.el | 6 +++---\r
+>  1 file changed, 3 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 4035fe8..b8cfbb8 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -241,9 +241,9 @@ every user interaction with notmuch."\r
+>         (let ((buf (generate-new-buffer (concat "*notmuch-msg-" id "*"))))\r
+>           (with-current-buffer buf\r
+>         (let ((coding-system-for-read 'no-conversion))\r
+> -         (call-process notmuch-command nil t nil "show" "--format=raw" id)\r
+> -         ,@body)\r
+> -       (kill-buffer buf))))))\r
+> +         (call-process notmuch-command nil t nil "show" "--format=raw" id))\r
+> +       ,@body)\r
+> +     (kill-buffer buf)))))\r
+>  \r
+>  (defun notmuch-show-turn-on-visual-line-mode ()\r
+>    "Enable Visual Line mode."\r
+> -- \r
+> 2.1.3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r