Re: [PATCH 1/5] go: reorganize the go bindings

diff --git a/cd/c324c1b65b9a9b66b72cde683bf63d183c72c3 b/cd/c324c1b65b9a9b66b72cde683bf63d183c72c3
new file mode 100644 (file)
index 0000000..3ee3ebb
--- /dev/null
+++ b/cd/c324c1b65b9a9b66b72cde683bf63d183c72c3
@@ -0,0 +1,97 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1E6D8431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  4 May 2012 11:43:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NemnAhXBtAO7 for <notmuch@notmuchmail.org>;\r
+       Fri,  4 May 2012 11:43:23 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
+       [18.9.25.12])\r
+       by olra.theworths.org (Postfix) with ESMTP id 781F3431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  4 May 2012 11:43:23 -0700 (PDT)\r
+X-AuditID: 1209190c-b7fad6d000000920-54-4fa4234ab509\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id BE.9D.02336.A4324AF4; Fri,  4 May 2012 14:43:23 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q44IhLjI002770; \r
+       Fri, 4 May 2012 14:43:22 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q44IhKv9009567\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Fri, 4 May 2012 14:43:21 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@MIT.EDU>)\r
+       id 1SQNTM-0005Mc-GK; Fri, 04 May 2012 14:43:20 -0400\r
+Date: Fri, 4 May 2012 14:43:20 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+Subject: Re: [PATCH 1/5] go: reorganize the go bindings\r
+Message-ID: <20120504184320.GO2704@mit.edu>\r
+References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>\r
+       <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <20120504183822.GN2704@mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <20120504183822.GN2704@mit.edu>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42IRYrdT0fVWXuJvsP05k8Xs1h9MFtdvzmR2\r
+       YPKYeP40m8ezVbeYA5iiuGxSUnMyy1KL9O0SuDLOf/3GWvCXreL08oIGxn2sXYwcHBICJhIX\r
+       mi27GDmBTDGJC/fWs3UxcnEICexjlPh08gwrhLOeUeLtq05mCOcEk8Tfmz+hypYwSlxY8YUd\r
+       pJ9FQEVi84u/LCA2m4CGxLb9yxlBbBEBU4kNDx6A1TALSEt8+93MBGILC5hLzJ7ykg3E5hXQ\r
+       lnj96zs7xNBVjBLre/oYIRKCEidnPmGBaNaSuPHvJRPI3SCDlv/jAAlzCuhI3FuwGqxcFOiG\r
+       KSe3sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Rrq5WaW6KWmlG5i\r
+       BIU1pyTPDsY3B5UOMQpwMCrx8O7mWOIvxJpYVlyZe4hRkoNJSZQ3QB4oxJeUn1KZkVicEV9U\r
+       mpNafIhRgoNZSYQ36etifyHelMTKqtSifJiUNAeLkjivitY7PyGB9MSS1OzU1ILUIpisDAeH\r
+       kgSvuhLQUMGi1PTUirTMnBKENBMHJ8hwHqDhHCA1vMUFibnFmekQ+VOMuhzzpmy9yijEkpef\r
+       lyolzssJUiQAUpRRmgc3B5aOXjGKA70lzCsGUsUDTGVwk14BLWECWiJtsAhkSUkiQkqqgXFH\r
+       pU+6T8NRt7ka7n6VSXGqpabhKXe6H22yUj53L/y07MEvJ2w/eBRYTPTq1+P0+3fz0YOKgLOa\r
+       3Lu9zrz6EdN19O7xYl2/xTMcL1dYK70OKHptuSLz67IVtgxnTEN4t/kW8Jw52qPE9v3Cmuss\r
+       0i+vpq9KOxj648TCp+/Uebyvx92VPWXSraTEUpyRaKjFXFScCADNgzFEIgMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 04 May 2012 18:43:24 -0000\r
+\r
+Quoth myself on May 04 at  2:38 pm:\r
+> Quoth Justus Winter on Apr 30 at  9:55 pm:\r
+> > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+> \r
+> Whole series LGTM (and yay gofmt!).  I have only two minor comments.\r
+> \r
+> It would be nice to have a little more log message for some of these.\r
+> Mostly the first one could use some explanation of why you're\r
+> rearranging the source tree and a mention that there are no changes to\r
+> the files (since this is hard to get from the diff).\r
+> \r
+> It would also be nice if this could optionally be built using the\r
+> libnotmuch and notmuch.h directly from the source tree containing the\r
+> Go bindings, rather than requiring them to be installed system-wide.\r
+> I don't know Go 1's build system well enough to know if there's an\r
+> easy way to do this.\r
+\r
+Oh, also a news patch would be good, though that can obviously be\r
+separate.\r