Re: [PATCH] Return error status from notmuch_message_tags_to_maildir_flags().

diff --git a/33/caa950f2e77b701cf7eff9e5ca628781b02519 b/33/caa950f2e77b701cf7eff9e5ca628781b02519
new file mode 100644 (file)
index 0000000..b5dc774
--- /dev/null
+++ b/33/caa950f2e77b701cf7eff9e5ca628781b02519
@@ -0,0 +1,105 @@
+Return-Path: <amdragon@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 659E2431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 27 Feb 2011 00:15:45 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id tQiWrq+J2DXv for <notmuch@notmuchmail.org>;\r
+       Sun, 27 Feb 2011 00:15:44 -0800 (PST)\r
+Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com\r
+       [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5C4D3431FB5\r
+       for <notmuch@notmuchmail.org>; Sun, 27 Feb 2011 00:15:44 -0800 (PST)\r
+Received: by qwc9 with SMTP id 9so2374802qwc.26\r
+       for <notmuch@notmuchmail.org>; Sun, 27 Feb 2011 00:15:42 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=domainkey-signature:mime-version:sender:in-reply-to:references:date\r
+       :x-google-sender-auth:message-id:subject:from:to:cc:content-type\r
+       :content-transfer-encoding;\r
+       bh=z2Xjgbcbjeydld4aHDovPZsKkspPY5CVO49kNRnv0JE=;\r
+       b=UwpSjWmc29p9evWpz9jgB3H360VMJFh1BrFvDd6T7DLpW5OxmyPJ1d/EHCrVgo3Af8\r
+       7gA3ofAqSfRC7EsBste9f5+dMHnqld8V0w32bpnepCEuQMVNj2z/6GkjbX3YhecL4GX7\r
+       IcVLXVVRGjxnb1uMVFhx+YVhWImr9elcRGG2s=\r
+DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
+       h=mime-version:sender:in-reply-to:references:date\r
+       :x-google-sender-auth:message-id:subject:from:to:cc:content-type\r
+       :content-transfer-encoding;\r
+       b=cEkz7sfyG3Id5je3hiDur9QuTJ0KyXAk9Mmp51Gb5j4yyyhdC8UTaP7XRjiaQKYICe\r
+       yHgQGwCvMoRdOV2fcfF3QRlvRunZFx9S06WYbLJj205TX6Hu88g1LMxeDPV43nMGc7F9\r
+       uCeeysgpiPwH7zHxAZYwa2hMuoOU5qygyuUHc=\r
+MIME-Version: 1.0\r
+Received: by 10.224.45.74 with SMTP id d10mr3514125qaf.304.1298794541563; Sun,\r
+       27 Feb 2011 00:15:41 -0800 (PST)\r
+Sender: amdragon@gmail.com\r
+Received: by 10.229.105.68 with HTTP; Sun, 27 Feb 2011 00:15:41 -0800 (PST)\r
+In-Reply-To: <b526f37593c021805e62f1a061a49ea20f09df0f.1297749638.git.rlb@defaultvalue.org>\r
+References: <cover.1297749638.git.rlb@defaultvalue.org>\r
+       <b526f37593c021805e62f1a061a49ea20f09df0f.1297749638.git.rlb@defaultvalue.org>\r
+Date: Sun, 27 Feb 2011 03:15:41 -0500\r
+X-Google-Sender-Auth: JBbqdFYBoNHM9x8XsabC5FMINxk\r
+Message-ID: <AANLkTi=-MJS1=O=Qpmhn6Tks5w_SOYvBtFM16N1+2oG1@mail.gmail.com>\r
+Subject: Re: [PATCH] Return error status from\r
+       notmuch_message_tags_to_maildir_flags().\r
+From: Austin Clements <amdragon@mit.edu>\r
+To: Rob Browning <rlb@defaultvalue.org>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 27 Feb 2011 08:15:45 -0000\r
+\r
+Looks good to me, but it appears that both callers of\r
+notmuch_message_tags_to_maildir_flags ignore the return value.  Both\r
+callers synchronize maildir flags immediately after thawing the tag\r
+changes on a message.  Perhaps they should instead synchronize\r
+*before* thawing and abort if the sync fails?\r
+\r
+On Tue, Feb 15, 2011 at 1:07 AM, Rob Browning <rlb@defaultvalue.org> wrote:\r
+> Signed-off-by: Rob Browning <rlb@defaultvalue.org>\r
+> ---\r
+> =A0lib/message.cc | =A0 =A02 +-\r
+> =A01 files changed, 1 insertions(+), 1 deletions(-)\r
+>\r
+> diff --git a/lib/message.cc b/lib/message.cc\r
+> index 0590f76..979fad5 100644\r
+> --- a/lib/message.cc\r
+> +++ b/lib/message.cc\r
+> @@ -1252,7 +1252,7 @@ notmuch_message_tags_to_maildir_flags (notmuch_mess=\r
+age_t *message)\r
+> =A0 =A0 talloc_free (to_set);\r
+> =A0 =A0 talloc_free (to_clear);\r
+>\r
+> - =A0 =A0return NOTMUCH_STATUS_SUCCESS;\r
+> + =A0 =A0return status;\r
+> =A0}\r
+>\r
+> =A0notmuch_status_t\r
+> --\r
+> 1.7.2.3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+>\r