RE: [PATCH v3] VIM: Improve moving between messages in a thread

diff --git a/63/d95c0e6f223f5bf388e717b9c2033944c47d86 b/63/d95c0e6f223f5bf388e717b9c2033944c47d86
new file mode 100644 (file)
index 0000000..77d4b73
--- /dev/null
+++ b/63/d95c0e6f223f5bf388e717b9c2033944c47d86
@@ -0,0 +1,84 @@
+Return-Path: <alpine.art.de@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EBC36431FC9\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 10:53:34 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.639\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.639 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       DNS_FROM_AHBL_RHSBL=2.438, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id a1NDSwZJdFWo for <notmuch@notmuchmail.org>;\r
+       Wed, 21 Jan 2015 10:53:31 -0800 (PST)\r
+Received: from mail-we0-f178.google.com (mail-we0-f178.google.com\r
+       [74.125.82.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 86F9B431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 10:53:31 -0800 (PST)\r
+Received: by mail-we0-f178.google.com with SMTP id p10so44804304wes.9\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 10:53:27 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=date:from:to:cc:message-id:in-reply-to:references:subject\r
+       :mime-version:content-type:content-transfer-encoding:attach;\r
+       bh=Jo0epJohfJO1rLuu0pNDXfy8JYumztPxlrwNI6LFRh0=;\r
+       b=v0S8Vsf3tMejhUa+eNF7/tJXGdSnRR3WQ9UvnJL6LHPdj2u1Y6zNjJjrjfBLrxZ7uT\r
+       83+dAnImvRZdlG8ow2x1jUUsGhdmS97kbZUpYcnsQySvUv/357A7qnh+s0ZOU+5P1HcN\r
+       PjguYUmwVXhtDF3bsLrCZAEGPXN4yv6i/FjhlPpS4YDvjErSNLDOYIlLfdwktuaOuEXU\r
+       JvMDfCsh91r4iBALZexibmWQbQGmhJk48G5C3VClol5FxIj1xWaR51nUC3V7cxtgaUG9\r
+       psWNredeuQ878+ak1/XWcyXZkSOIoSZQNVR6gDz6bN37GSyath6DDNFSwOIYbZeckWCC\r
+       NOAA==\r
+X-Received: by 10.181.12.11 with SMTP id em11mr59663793wid.1.1421866407144;\r
+       Wed, 21 Jan 2015 10:53:27 -0800 (PST)\r
+Received: from localhost (p4FFB8A19.dip0.t-ipconnect.de. [79.251.138.25])\r
+       by mx.google.com with ESMTPSA id s9sm8405515wiz.12.2015.01.21.10.53.25\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Wed, 21 Jan 2015 10:53:26 -0800 (PST)\r
+Date: Wed, 21 Jan 2015 19:53:56 +0100\r
+From: Franz Fellner <alpine.art.de@gmail.com>\r
+To: Bartosz Telenczuk <telenczuk@unic.cnrs-gif.fr>\r
+Message-ID: <54bff5c426e50_5b9d145d304d6@TP_L520.notmuch>\r
+In-Reply-To: <54b45d071fd20_7f93fe5bd4401f087@bts-MacBook-Pro.local.notmuch>\r
+References: <1412618116-27586-1-git-send-email-imain@stemwinder.org>\r
+       <1413828111-2879-1-git-send-email-imain@stemwinder.org>\r
+       <54b45d071fd20_7f93fe5bd4401f087@bts-MacBook-Pro.local.notmuch>\r
+Subject: RE: [PATCH v3] VIM: Improve moving between messages in a thread\r
+Mime-Version: 1.0\r
+Content-Type: text/plain;\r
+ charset=utf-8\r
+Content-Transfer-Encoding: 7bit\r
+Attach: \r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 Jan 2015 18:53:35 -0000\r
+\r
+Bartosz Telenczuk wrote:\r
+> Hi Ian,\r
+> \r
+> The patch looks good. I tested it on my system and it works fine.  I just have one suggestion regarding coding style.\r
+> \r
+> > +function! s:show_prev_msg()\r
+> >  function! s:show_next_msg()\r
+> \r
+> Since these functions are almost the same, you could avoid code repetition by replacing them by a function which takes (positive or negative) increment as an argument.\r
+\r
+I think the API should be clear and easy to understand, because people will probably bind them to custom shortcuts. You should not have to think about what that weird extra parameter (-1, false, ...) means and go read the docs.\r
+But I agree that the code duplication is not optimal. The code in Ians repo already has split out the ruby code. There is still code duplication. But that can easily be split out into a function on its own. \r
+\r
+Franz\r