Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH

diff --git a/8b/87e3dbce60158cb578c2be95f644c8ff008b5d b/8b/87e3dbce60158cb578c2be95f644c8ff008b5d
new file mode 100644 (file)
index 0000000..d8f6307
--- /dev/null
+++ b/8b/87e3dbce60158cb578c2be95f644c8ff008b5d
@@ -0,0 +1,82 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 1BF556DE091B\r
+ for <notmuch@notmuchmail.org>; Thu, 11 Aug 2016 22:51:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.008\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.008 tagged_above=-999 required=5 tests=[AWL=0.003,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id GY07eHWYz2ge for <notmuch@notmuchmail.org>;\r
+ Thu, 11 Aug 2016 22:51:24 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 1BE346DE0362\r
+ for <notmuch@notmuchmail.org>; Thu, 11 Aug 2016 22:51:23 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bY5NV-0006ad-NV; Fri, 12 Aug 2016 01:51:33 -0400\r
+Received: (nullmailer pid 18608 invoked by uid 1000);\r
+ Fri, 12 Aug 2016 05:51:16 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 01/16] add util/search-path.{c,\r
+ h} to test for executables in $PATH\r
+In-Reply-To: <1467970047-8013-2-git-send-email-dkg@fifthhorseman.net>\r
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1467970047-8013-2-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 12 Aug 2016 14:51:16 +0900\r
+Message-ID: <878tw2r0vf.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 12 Aug 2016 05:51:32 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> This is a utility function we can use to see whether an executa>\r
+> +    if (strchr (exename, '/')) {\r
+> +    if (0 == access (exename, X_OK))\r
+> +        return TRUE;\r
+> +    else\r
+> +        return FALSE;\r
+> +    }\r
+\r
+Should we distinguish between relative and absolute paths here?  I can't\r
+think of any security implications, but I'm wondering if a relative path\r
+is likely just a user error.\r
+\r
+> +    path = (char *) malloc (n);\r
+> +    if (! path)\r
+> +        return FALSE;\r
+\r
+I kindof hate hiding the error here, although I agree it's\r
+unlikely. What about the unixy return 0 ok, 1 not found -1 error?\r
+\r
+> +    confstr (_CS_PATH, path, n);\r
+> +    }\r
+> +\r
+> +    tok = strtok_r (path, ":", &save);\r
+> +    while (tok) {\r
+\r
+I guess it's fine to modify path here, but another option is\r
+strtok_len (in string-util.h)\r
+\r